#3427 highlighting: add Q_ASSERT

pbek · pbek · commit 0886896b0a84 · 2026-01-05T11:23:55.000+01:00
Signed-off-by: Patrizio Bekerle &lt;patrizio@bekerle.com&gt;
diff --git a/src/helpers/qownnotesmarkdownhighlighter.cpp b/src/helpers/qownnotesmarkdownhighlighter.cpp
@@ -40,11 +40,10 @@ QOwnNotesMarkdownHighlighter::QOwnNotesMarkdownHighlighter(QTextDocument *parent
 }
 
 void QOwnNotesMarkdownHighlighter::updateCurrentNote(Note *note) {
-    if (note != nullptr) {
-        _currentNote = note;
-    }
+    Q_ASSERT(note);
 
-    _hasEncrypted = _currentNote ? _currentNote->hasEncryptedNoteText() : false;
+    _currentNote = note;
+    _hasEncrypted = _currentNote->hasEncryptedNoteText();
     _highlightEncrypted = false;    // Reset state when note changes
 }
 

Original file line number	Diff line number	Diff line change
`@@ -40,11 +40,10 @@ QOwnNotesMarkdownHighlighter::QOwnNotesMarkdownHighlighter(QTextDocument *parent`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`void QOwnNotesMarkdownHighlighter::updateCurrentNote(Note *note) {`
`43`		`- if (note != nullptr) {`
`44`		`- _currentNote = note;`
`45`		`- }`
	`43`	`+ Q_ASSERT(note);`
`46`	`44`
`47`		`- _hasEncrypted = _currentNote ? _currentNote->hasEncryptedNoteText() : false;`
	`45`	`+ _currentNote = note;`
	`46`	`+ _hasEncrypted = _currentNote->hasEncryptedNoteText();`
`48`	`47`	`_highlightEncrypted = false; // Reset state when note changes`
`49`	`48`	`}`
`50`	`49`