#3494 icons: fix low-contrast search icons in "Link to a URL or note" and Settings dialogs

Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>

Author: pbek

CHANGELOG.md

@@ -5,6 +5,9 @@
 - Fixed a build failure with older Qt5 versions in XDG global shortcut portal token
   generation by only using `QUuid::WithoutBraces` on Qt >= 5.11 and falling back to
   brace removal on older Qt5 (for [#2462](https://github.com/pbek/QOwnNotes/issues/2462))
+- Fixed low-contrast search icons in the "Link to a URL or note" and Settings dialogs
+  by switching the search field icon between light and dark variants based on the
+  active dark mode color setting (for [#3494](https://github.com/pbek/QOwnNotes/issues/3494))
 
 ## 26.3.10
 

src/dialogs/linkdialog.cpp

@@ -78,6 +78,26 @@ LinkDialog::LinkDialog(int page, const QString &dialogTitle, QWidget *parent)
     ui->notesListWidget->installEventFilter(this);
     ui->notesListWidget->setRootIsDecorated(false);
 
+    // Change the search icon between dark and light mode
+    const QString searchIconFileName =
+        SettingsService().value(QStringLiteral("darkModeColors")).toBool()
+            ? QStringLiteral("search-notes-dark.svg")
+            : QStringLiteral("search-notes.svg");
+    static const QRegularExpression searchIconRegex(
+        QStringLiteral("background-image: url\\(:.+\\);"));
+
+    QString searchLineEditStyleSheet = ui->searchLineEdit->styleSheet();
+    searchLineEditStyleSheet.replace(
+        searchIconRegex,
+        QStringLiteral("background-image: url(:/images/%1);").arg(searchIconFileName));
+    ui->searchLineEdit->setStyleSheet(searchLineEditStyleSheet);
+
+    QString headingSearchLineEditStyleSheet = ui->headingSearchLineEdit->styleSheet();
+    headingSearchLineEditStyleSheet.replace(
+        searchIconRegex,
+        QStringLiteral("background-image: url(:/images/%1);").arg(searchIconFileName));
+    ui->headingSearchLineEdit->setStyleSheet(headingSearchLineEditStyleSheet);
+
     const bool showSubfolders = NoteFolder::isCurrentShowSubfolders();
     ui->notesListWidget->setColumnHidden(1, !showSubfolders);
     ui->notesListWidget->setColumnHidden(2, !showSubfolders);

src/dialogs/settingsdialog.cpp

@@ -107,6 +107,32 @@ SettingsDialog::SettingsDialog(int page, QWidget *parent)
     ui->calDavCalendarGroupBox->hide();
     _newScriptName = tr("New script");
 
+    // Change the search icon between dark and light mode
+    const QString searchIconFileName =
+        SettingsService().value(QStringLiteral("darkModeColors")).toBool()
+            ? QStringLiteral("search-notes-dark.svg")
+            : QStringLiteral("search-notes.svg");
+    static const QRegularExpression searchIconRegex(
+        QStringLiteral("background-image: url\\(:.+\\);"));
+    const QString searchIconStyle =
+        QStringLiteral("background-image: url(:/images/%1);").arg(searchIconFileName);
+
+    QString styleSheet = ui->searchLineEdit->styleSheet();
+    styleSheet.replace(searchIconRegex, searchIconStyle);
+    ui->searchLineEdit->setStyleSheet(styleSheet);
+
+    styleSheet = ui->languageSearchLineEdit->styleSheet();
+    styleSheet.replace(searchIconRegex, searchIconStyle);
+    ui->languageSearchLineEdit->setStyleSheet(styleSheet);
+
+    styleSheet = ui->shortcutSearchLineEdit->styleSheet();
+    styleSheet.replace(searchIconRegex, searchIconStyle);
+    ui->shortcutSearchLineEdit->setStyleSheet(styleSheet);
+
+    styleSheet = ui->scriptSearchLineEdit->styleSheet();
+    styleSheet.replace(searchIconRegex, searchIconStyle);
+    ui->scriptSearchLineEdit->setStyleSheet(styleSheet);
+
 #ifdef Q_OS_WIN32
     QString downloadText =
         tr("You can download your git client here: <a "