Skip to content

Commit eac0778

Browse files
committed
#3357 nextclouddeckdialog: treat new item and listing the same
Signed-off-by: Patrizio Bekerle <[email protected]>
1 parent 9083a7e commit eac0778

File tree

4 files changed

+17
-21
lines changed

4 files changed

+17
-21
lines changed

src/dialogs/nextclouddeckdialog.cpp

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,20 @@
1313

1414
NextcloudDeckDialog::NextcloudDeckDialog(QWidget *parent, bool listMode)
1515
: MasterDialog(parent), ui(new Ui::NextcloudDeckDialog) {
16+
Q_UNUSED(listMode)
1617
ui->setupUi(this);
1718
afterSetupUI();
1819
setupUi();
1920
_currentCard = NextcloudDeckService::Card();
20-
21-
ui->dueDateTimeEdit->setDateTime(QDateTime::currentDateTime());
2221
ui->saveButton->setEnabled(false);
2322
ui->dueDateTimeCheckBox->setChecked(true);
23+
ui->newItemEdit->setFocus();
24+
25+
// Set default due date to one hour from now
26+
ui->dueDateTimeEdit->setDateTime(QDateTime::currentDateTime().addSecs(3600));
2427

2528
// Hide currently unused UI elements
2629
ui->showDueTodayItemsOnlyCheckBox->setHidden(true);
27-
28-
if (listMode) {
29-
setWindowTitle(tr("Manage Nextcloud Deck Cards"));
30-
ui->newItemEdit->setFocus();
31-
} else {
32-
ui->titleLineEdit->setFocus();
33-
ui->selectFrame->setHidden(true);
34-
}
3530
}
3631

3732
NextcloudDeckDialog::~NextcloudDeckDialog() { delete ui; }
@@ -128,6 +123,9 @@ void NextcloudDeckDialog::on_saveButton_clicked() {
128123

129124
// Reload the card list to reflect the changes
130125
reloadCardList();
126+
127+
ui->newItemEdit->clear();
128+
ui->newItemEdit->setFocus();
131129
}
132130

133131
if (cardIdToUpdate == -1) {
@@ -236,7 +234,7 @@ void NextcloudDeckDialog::resetEditFrameControls() {
236234
ui->titleLineEdit->setText(QString());
237235
ui->descriptionTextEdit->setPlainText(QString());
238236
ui->dueDateTimeCheckBox->setChecked(false);
239-
ui->dueDateTimeEdit->hide();
237+
ui->dueDateTimeEdit->setEnabled(false);
240238
ui->saveButton->setEnabled(false);
241239
_currentCard = NextcloudDeckService::Card();
242240
}
@@ -289,4 +287,7 @@ void NextcloudDeckDialog::on_newItemEdit_returnPressed() {
289287
ui->titleLineEdit->setText(ui->newItemEdit->text());
290288
ui->descriptionTextEdit->setFocus();
291289
ui->newItemEdit->clear();
290+
// Set default due date to one hour from now
291+
ui->dueDateTimeEdit->setDateTime(QDateTime::currentDateTime().addSecs(3600));
292+
ui->dueDateTimeCheckBox->setChecked(true);
292293
}

src/dialogs/nextclouddeckdialog.ui

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
</rect>
1212
</property>
1313
<property name="windowTitle">
14-
<string>Insert Nextcloud Deck card link</string>
14+
<string>Manage Nextcloud Deck Cards</string>
1515
</property>
1616
<layout class="QGridLayout" name="gridLayout">
1717
<item row="0" column="1">

src/mainwindow.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12450,10 +12450,5 @@ void MainWindow::on_actionReattach_panels_triggered() {
1245012450
}
1245112451

1245212452
void MainWindow::on_actionManage_Nextcloud_Deck_cards_triggered() {
12453-
if (!nextCloudDeckCheck()) {
12454-
return;
12455-
}
12456-
12457-
auto *dialog = new NextcloudDeckDialog(this, true);
12458-
dialog->exec();
12453+
on_actionInsert_Nextcloud_Deck_card_triggered();
1245912454
}

src/mainwindow.ui

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2815,9 +2815,6 @@ li.checked::marker { content: &quot;\2612&quot;; }
28152815
<property name="text">
28162816
<string>Insert Nextcloud Deck card link</string>
28172817
</property>
2818-
<property name="shortcut">
2819-
<string notr="true">Ctrl+Alt+D</string>
2820-
</property>
28212818
</action>
28222819
<action name="actionCopy_path_to_note_to_clipboard">
28232820
<property name="text">
@@ -2881,6 +2878,9 @@ li.checked::marker { content: &quot;\2612&quot;; }
28812878
<property name="text">
28822879
<string>Manage Nextcloud Deck cards</string>
28832880
</property>
2881+
<property name="shortcut">
2882+
<string>Ctrl+Alt+D</string>
2883+
</property>
28842884
</action>
28852885
</widget>
28862886
<layoutdefault spacing="6" margin="11"/>

0 commit comments

Comments
 (0)