fix: shellscript errors

Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>

Author: pbek

docker/entrypoint.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 set -eu
 
 chown www-data:root /var/www/deploy
@@ -31,8 +31,10 @@ file_env() {
   local var="$1"
   local fileVar="${var}_FILE"
   local def="${2:-}"
-  local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//")
-  local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//")
+  local varValue
+  local fileVarValue
+  varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//")
+  fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//")
   if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then
     echo >&2 "error: both $var and $fileVar are set (but are exclusive)"
     exit 1
@@ -99,14 +101,14 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP
     else
       rsync_options="-rlD"
     fi
-    rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/
+    rsync "$rsync_options" --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/
 
     for dir in config data custom_apps themes; do
       if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then
-        rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/
+        rsync "$rsync_options" --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/
       fi
     done
-    rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/
+    rsync "$rsync_options" --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/
     echo "Initializing finished"
 
     #install

docker/nextcloud/sign-app.sh

@@ -15,8 +15,8 @@ rm -rf ${APP_DEST} &&
   echo "📂 Deployment directory prepared." &&
   rsync -a --exclude .git* --exclude .gitlab-ci* --exclude .github --exclude screenshot* \
     --exclude docs --exclude tests --exclude vendor --exclude package.* --exclude composer.json --exclude composer.lock \
-    --exclude Makefile --exclude *.db* --exclude docker --exclude *.phar \
-    --exclude *.gz --exclude .idea --exclude .renovaterc.json --exclude .php-cs* \
+    --exclude Makefile --exclude '*.db*' --exclude docker --exclude '*.phar' \
+    --exclude '*.gz' --exclude .idea --exclude .renovaterc.json --exclude '.php-cs*' \
     --exclude phpstan.* --exclude phpunit.* --exclude psalm.xml --exclude shell.nix \
     --exclude .envrc --exclude .direnv --exclude term.kdl --exclude .phpunit.result.cache \
     --exclude justfile --exclude treefmt.toml --exclude .devenv --exclude flake.* \
@@ -37,12 +37,12 @@ rm -rf ${APP_DEST} &&
   --certificate=${CERT_PATH}/${APP_NAME}.crt --path=${APP_DEST}" www-data &&
   echo "🔐 App signed successfully." &&
   cp ${APP_DEST}/appinfo/signature.json ${APP_SOURCE}/appinfo &&
-  echo "\n🔍 Reviewing files to be included in the archive:\n" &&
+  printf "\n🔍 Reviewing files to be included in the archive:\n\n" &&
   find ${APP_DEST} -type f | sort &&
-  echo "\n⏸️ Press Enter to continue with archiving.\n" &&
-  read line &&
+  printf "\n⏸️ Press Enter to continue with archiving.\n\n" &&
+  read -r _ &&
   tar czf ${DEPLOYMENT_FILE} -C ${APP_DEST}/.. ${APP_NAME} &&
   echo "📦 Archive created." &&
-  echo "\n🔐 Signature for your app archive:\n" &&
+  printf "\n🔐 Signature for your app archive:\n\n" &&
   openssl dgst -sha512 -sign ${CERT_PATH}/${APP_NAME}.key ${DEPLOYMENT_FILE} | openssl base64 &&
   echo

docker/owncloud/sign-app.sh

@@ -11,12 +11,12 @@ DEPLOYMENT_FILE=${APP_SOURCE}/${APP_NAME}-oc.tar.gz
 
 rm -rf ${APP_DEST} &&
   mkdir ${APP_DEST} &&
-  rsync -a --exclude .git* --exclude .gitlab-ci* --exclude .github --exclude screenshot* --exclude docs --exclude tests --exclude vendor --exclude package.* --exclude Makefile --exclude *.db* --exclude docker --exclude *.phar --exclude *.gz --exclude .idea ${APP_SOURCE}/ ${APP_DEST} &&
+  rsync -a --exclude .git* --exclude .gitlab-ci* --exclude .github --exclude screenshot* --exclude docs --exclude tests --exclude vendor --exclude package.* --exclude Makefile --exclude '*.db*' --exclude docker --exclude '*.phar' --exclude '*.gz' --exclude .idea ${APP_SOURCE}/ ${APP_DEST} &&
   su -m -c "./occ integrity:sign-app \
   --privateKey=${CERT_PATH}/${APP_NAME}.key \
   --certificate=${CERT_PATH}/${APP_NAME}.crt --path=${APP_DEST}" www-data &&
   cp ${APP_DEST}/appinfo/signature.json ${APP_SOURCE}/appinfo &&
   tar cz ${APP_DEST}/../qownnotesapi/ >${DEPLOYMENT_FILE} &&
-  echo "\nSignature for your app archive:\n" &&
+  printf "\nSignature for your app archive:\n\n" &&
   openssl dgst -sha512 -sign ${CERT_PATH}/${APP_NAME}.key ${DEPLOYMENT_FILE} | openssl base64 &&
   echo