Skip to content

Commit 16e8c94

Browse files
philmdpm215
authored andcommitted
tests/qtest/boot-serial-test: Improve ASM comments of PL011 tests
Re-indent ASM comments adding the 'loop:' label. Signed-off-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Reviewed-by: Fabiano Rosas <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
1 parent 593b910 commit 16e8c94

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

tests/qtest/boot-serial-test.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,18 +70,18 @@ static const uint8_t kernel_plml605[] = {
7070
};
7171

7272
static const uint8_t bios_raspi2[] = {
73-
0x08, 0x30, 0x9f, 0xe5, /* ldr r3,[pc,#8] Get base */
74-
0x54, 0x20, 0xa0, 0xe3, /* mov r2,#'T' */
75-
0x00, 0x20, 0xc3, 0xe5, /* strb r2,[r3] */
76-
0xfb, 0xff, 0xff, 0xea, /* b loop */
77-
0x00, 0x10, 0x20, 0x3f, /* 0x3f201000 = UART0 base addr */
73+
0x08, 0x30, 0x9f, 0xe5, /* loop: ldr r3, [pc, #8] Get &UART0 */
74+
0x54, 0x20, 0xa0, 0xe3, /* mov r2, #'T' */
75+
0x00, 0x20, 0xc3, 0xe5, /* strb r2, [r3] *TXDAT = 'T' */
76+
0xfb, 0xff, 0xff, 0xea, /* b -12 (loop) */
77+
0x00, 0x10, 0x20, 0x3f, /* UART0: 0x3f201000 */
7878
};
7979

8080
static const uint8_t kernel_aarch64[] = {
81-
0x81, 0x0a, 0x80, 0x52, /* mov w1, #0x54 */
82-
0x02, 0x20, 0xa1, 0xd2, /* mov x2, #0x9000000 */
83-
0x41, 0x00, 0x00, 0x39, /* strb w1, [x2] */
84-
0xfd, 0xff, 0xff, 0x17, /* b -12 (loop) */
81+
0x81, 0x0a, 0x80, 0x52, /* loop: mov w1, #'T' */
82+
0x02, 0x20, 0xa1, 0xd2, /* mov x2, #0x9000000 Load UART0 */
83+
0x41, 0x00, 0x00, 0x39, /* strb w1, [x2] *TXDAT = 'T' */
84+
0xfd, 0xff, 0xff, 0x17, /* b -12 (loop) */
8585
};
8686

8787
static const uint8_t kernel_nrf51[] = {

0 commit comments

Comments
 (0)