Skip to content

Commit 2588a5f

Browse files
yliu80Fabiano Rosas
authored andcommitted
multifd: bugfix for incorrect migration data with QPL compression
When QPL compression is enabled on the migration channel and the same dirty page changes from a normal page to a zero page in the iterative memory copy, the dirty page will not be updated to a zero page again on the target side, resulting in incorrect memory data on the source and target sides. The root cause is that the target side does not record the normal pages to the receivedmap. The solution is to add ramblock_recv_bitmap_set_offset in target side to record the normal pages. Signed-off-by: Yuan Liu <[email protected]> Reviewed-by: Jason Zeng <[email protected]> Reviewed-by: Peter Xu <[email protected]> Message-Id: <[email protected]> Signed-off-by: Fabiano Rosas <[email protected]>
1 parent cdc3970 commit 2588a5f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

migration/multifd-qpl.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -679,6 +679,7 @@ static int multifd_qpl_recv(MultiFDRecvParams *p, Error **errp)
679679
qpl->zlen[i] = be32_to_cpu(qpl->zlen[i]);
680680
assert(qpl->zlen[i] <= multifd_ram_page_size());
681681
zbuf_len += qpl->zlen[i];
682+
ramblock_recv_bitmap_set_offset(p->block, p->normal[i]);
682683
}
683684

684685
/* read compressed pages */

0 commit comments

Comments
 (0)