Skip to content

Commit 652f6d8

Browse files
mchehabmstsirkin
authored andcommitted
acpi/ghes: better name the offset of the hardware error firmware
The hardware error firmware is where HEST error structures are stored. Those can be GHESv2, but they can also be other types. Better name the location of the hardware error. No functional changes. Signed-off-by: Mauro Carvalho Chehab <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Reviewed-by: Igor Mammedov <[email protected]> Message-Id: <ddbb94294bafee998f12fede3ba0b05dae5ee45f.1736945236.git.mchehab+huawei@kernel.org> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
1 parent 4651745 commit 652f6d8

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

hw/acpi/generic_event_device.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,15 +363,15 @@ static const VMStateDescription vmstate_ghes = {
363363
.version_id = 1,
364364
.minimum_version_id = 1,
365365
.fields = (const VMStateField[]) {
366-
VMSTATE_UINT64(ghes_addr_le, AcpiGhesState),
366+
VMSTATE_UINT64(hw_error_le, AcpiGhesState),
367367
VMSTATE_END_OF_LIST()
368368
},
369369
};
370370

371371
static bool ghes_needed(void *opaque)
372372
{
373373
AcpiGedState *s = opaque;
374-
return s->ghes_state.ghes_addr_le;
374+
return s->ghes_state.hw_error_le;
375375
}
376376

377377
static const VMStateDescription vmstate_ghes_state = {

hw/acpi/ghes.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s,
359359

360360
/* Create a read-write fw_cfg file for Address */
361361
fw_cfg_add_file_callback(s, ACPI_HW_ERROR_ADDR_FW_CFG_FILE, NULL, NULL,
362-
NULL, &(ags->ghes_addr_le), sizeof(ags->ghes_addr_le), false);
362+
NULL, &(ags->hw_error_le), sizeof(ags->hw_error_le), false);
363363

364364
ags->present = true;
365365
}
@@ -385,7 +385,7 @@ void ghes_record_cper_errors(const void *cper, size_t len,
385385
}
386386
ags = &acpi_ged_state->ghes_state;
387387

388-
start_addr = le64_to_cpu(ags->ghes_addr_le);
388+
start_addr = le64_to_cpu(ags->hw_error_le);
389389

390390
start_addr += source_id * sizeof(uint64_t);
391391

include/hw/acpi/ghes.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ enum {
6565
};
6666

6767
typedef struct AcpiGhesState {
68-
uint64_t ghes_addr_le;
68+
uint64_t hw_error_le;
6969
bool present; /* True if GHES is present at all on this board */
7070
} AcpiGhesState;
7171

0 commit comments

Comments
 (0)