Skip to content

Commit 8f78378

Browse files
calmisibonzini
authored andcommitted
i386/topology: Update the comment of x86_apicid_from_topo_ids()
Update the comment of x86_apicid_from_topo_ids() to match the current implementation, Signed-off-by: Xiaoyao Li <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 00ec7be commit 8f78378

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

include/hw/i386/topology.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,10 @@ static inline unsigned apicid_pkg_offset(X86CPUTopoInfo *topo_info)
121121
}
122122

123123
/*
124-
* Make APIC ID for the CPU based on Pkg_ID, Core_ID, SMT_ID
124+
* Make APIC ID for the CPU based on topology and IDs of each topology level.
125125
*
126-
* The caller must make sure core_id < nr_cores and smt_id < nr_threads.
126+
* The caller must make sure the ID of each level doesn't exceed the width of
127+
* the level.
127128
*/
128129
static inline apic_id_t x86_apicid_from_topo_ids(X86CPUTopoInfo *topo_info,
129130
const X86CPUTopoIDs *topo_ids)

0 commit comments

Comments
 (0)