Skip to content

Commit 9a9320a

Browse files
author
Fabiano Rosas
committed
tests/qtest/virtio-iommu-test: Don't pass uninitialized data into qtest_memwrite
Valgrind complains about: Use of uninitialised value of size 8 & Conditional jump or move depends on uninitialised value(s) both at: at 0x5265931: _itoa_word (_itoa.c:180) by 0x527EEC7: __vfprintf_internal (vfprintf-internal.c:1687) by 0x528C8B0: __vsprintf_internal (iovsprintf.c:96) by 0x526B920: sprintf (sprintf.c:30) by 0x1296C7: qtest_memwrite (libqtest.c:1273) by 0x193C04: send_map (virtio-iommu-test.c:125) by 0x194392: test_attach_detach (virtio-iommu-test.c:214) by 0x17BDE7: run_one_test (qos-test.c:181) by 0x4B0699D: test_case_run (gtestutils.c:2900) by 0x4B0699D: g_test_run_suite_internal (gtestutils.c:2988) by 0x4B068B2: g_test_run_suite_internal (gtestutils.c:3005) by 0x4B068B2: g_test_run_suite_internal (gtestutils.c:3005) by 0x4B068B2: g_test_run_suite_internal (gtestutils.c:3005) Uninitialised value was created by a stack allocation at 0x193AFD: send_map (virtio-iommu-test.c:103) Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Message-Id: <[email protected]> Signed-off-by: Fabiano Rosas <[email protected]>
1 parent a475e5d commit 9a9320a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/qtest/virtio-iommu-test.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ static int send_map(QTestState *qts, QVirtioIOMMU *v_iommu,
105105
QVirtQueue *vq = v_iommu->vq;
106106
uint64_t ro_addr, wr_addr;
107107
uint32_t free_head;
108-
struct virtio_iommu_req_map req;
108+
struct virtio_iommu_req_map req = {};
109109
size_t ro_size = sizeof(req) - sizeof(struct virtio_iommu_req_tail);
110110
size_t wr_size = sizeof(struct virtio_iommu_req_tail);
111111
struct virtio_iommu_req_tail buffer;
@@ -147,7 +147,7 @@ static int send_unmap(QTestState *qts, QVirtioIOMMU *v_iommu,
147147
QVirtQueue *vq = v_iommu->vq;
148148
uint64_t ro_addr, wr_addr;
149149
uint32_t free_head;
150-
struct virtio_iommu_req_unmap req;
150+
struct virtio_iommu_req_unmap req = {};
151151
size_t ro_size = sizeof(req) - sizeof(struct virtio_iommu_req_tail);
152152
size_t wr_size = sizeof(struct virtio_iommu_req_tail);
153153
struct virtio_iommu_req_tail buffer;

0 commit comments

Comments
 (0)