LibWeb: Implement the OscillatorNode.detune attribute

Author: tcl3

Libraries/LibWeb/WebAudio/OscillatorNode.cpp

@@ -4,6 +4,7 @@
  * SPDX-License-Identifier: BSD-2-Clause
  */
 
+#include <AK/Math.h>
 #include <LibWeb/Bindings/Intrinsics.h>
 #include <LibWeb/Bindings/OscillatorNodePrototype.h>
 #include <LibWeb/WebAudio/AudioParam.h>
@@ -43,6 +44,7 @@ WebIDL::ExceptionOr<GC::Ref<OscillatorNode>> OscillatorNode::construct_impl(JS::
 OscillatorNode::OscillatorNode(JS::Realm& realm, GC::Ref<BaseAudioContext> context, OscillatorOptions const& options)
     : AudioScheduledSourceNode(realm, context)
     , m_frequency(AudioParam::create(realm, options.frequency, -context->nyquist_frequency(), context->nyquist_frequency(), Bindings::AutomationRate::ARate))
+    , m_detune(AudioParam::create(realm, options.detune, -1200 * AK::log2(NumericLimits<float>::max()), 1200 * AK::log2(NumericLimits<float>::max()), Bindings::AutomationRate::ARate))
 {
 }
 
@@ -83,6 +85,7 @@ void OscillatorNode::visit_edges(Cell::Visitor& visitor)
 {
     Base::visit_edges(visitor);
     visitor.visit(m_frequency);
+    visitor.visit(m_detune);
 }
 
 }

Libraries/LibWeb/WebAudio/OscillatorNode.h

@@ -34,6 +34,8 @@ class OscillatorNode : public AudioScheduledSourceNode {
     WebIDL::ExceptionOr<void> set_type(Bindings::OscillatorType);
 
     GC::Ref<AudioParam const> frequency() const { return m_frequency; }
+    GC::Ref<AudioParam const> detune() const { return m_detune; }
+
     WebIDL::UnsignedLong number_of_inputs() override { return 0; }
     WebIDL::UnsignedLong number_of_outputs() override { return 1; }
 
@@ -51,6 +53,9 @@ class OscillatorNode : public AudioScheduledSourceNode {
 
     // https://webaudio.github.io/web-audio-api/#dom-oscillatornode-frequency
     GC::Ref<AudioParam> m_frequency;
+
+    // https://webaudio.github.io/web-audio-api/#dom-oscillatornode-detune
+    GC::Ref<AudioParam> m_detune;
 };
 
 }

Libraries/LibWeb/WebAudio/OscillatorNode.idl

@@ -24,6 +24,6 @@ interface OscillatorNode : AudioScheduledSourceNode {
     constructor(BaseAudioContext context, optional OscillatorOptions options = {});
     attribute OscillatorType type;
     readonly attribute AudioParam frequency;
-    [FIXME] readonly attribute AudioParam detune;
+    readonly attribute AudioParam detune;
     [FIXME] undefined setPeriodicWave(PeriodicWave periodicWave);
 };