llvmPackages.clang: embed resource directory in Clang libraries

When Clang is statically linked against other programs they are unable to
find the headers in Clang's resource directory. Typically the resource
directory is found by searching a path relative to argv[0] but this
would only really work for Clang itself due to each binary having a
separate prefix (and not in Nix because of the full resource directory
being split between multiple derivations and assembled in the wrapper).

Because users of Clang as a library typically only need include in order
for parsing to succeed, let's set that as the resource directory. The LLVM
patch to make this work was sent upstream in llvm/llvm-project#145996,
I intend to land it upstream and drop it from this PR.

Author: pcc

pkgs/development/compilers/llvm/common/clang/default.nix

@@ -158,6 +158,9 @@ stdenv.mkDerivation (
         (lib.cmakeFeature "LLVM_TABLEGEN_EXE" "${buildLlvmTools.tblgen}/bin/llvm-tblgen")
         (lib.cmakeFeature "CLANG_TABLEGEN" "${buildLlvmTools.tblgen}/bin/clang-tblgen")
       ]
+      ++ lib.optionals (lib.versionAtLeast release_version "21") [
+        (lib.cmakeFeature "CLANG_RESOURCE_DIR" "${placeholder "lib"}/lib/clang/${lib.versions.major release_version}")
+      ]
       ++ lib.optionals (lib.versionAtLeast release_version "17") [
         (lib.cmakeBool "LLVM_INCLUDE_TESTS" false)
       ]
@@ -190,6 +193,11 @@ stdenv.mkDerivation (
           --replace-fail 'StringRef P = llvm::sys::path::parent_path(D.Dir);' 'StringRef P = "${lib.getLib libllvm}";'
         (cd tools && ln -s ../../clang-tools-extra extra)
       ''
+      + lib.optionalString (lib.versionAtLeast release_version "21") ''
+        # This patch needs to be applied to the parent of the clang directory.
+        chmod -R +w ../cmake
+        (cd .. && patch -p1 < ${./resource-dir.diff})
+      ''
       + lib.optionalString stdenv.hostPlatform.isMusl ''
         sed -i -e 's/lgcc_s/lgcc_eh/' lib/Driver/ToolChains/*.cpp
       '';
@@ -211,7 +219,7 @@ stdenv.mkDerivation (
         mkdir -p $lib/lib/clang
         mv $lib/lib/17 $lib/lib/clang/17
       '')
-      + (lib.optionalString (lib.versionAtLeast release_version "19") ''
+      + (lib.optionalString ((lib.versionAtLeast release_version "19") && !(lib.versionAtLeast release_version "21")) ''
         mv $out/lib/clang $lib/lib/clang
       '')
       + ''

pkgs/development/compilers/llvm/common/clang/resource-dir.diff

@@ -0,0 +1,13 @@
+diff --git a/cmake/Modules/GetClangResourceDir.cmake b/cmake/Modules/GetClangResourceDir.cmake
+index def5bd60424e..9fd585729b0f 100644
+--- a/cmake/Modules/GetClangResourceDir.cmake
++++ b/cmake/Modules/GetClangResourceDir.cmake
+@@ -10,7 +10,7 @@ function(get_clang_resource_dir out_var)
+   cmake_parse_arguments(ARG "" "PREFIX;SUBDIR" "" ${ARGN})
+ 
+   if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "")
+-    set(ret_dir bin/${CLANG_RESOURCE_DIR})
++    cmake_path(APPEND bin ${CLANG_RESOURCE_DIR} OUTPUT_VARIABLE ret_dir)
+   else()
+     if (NOT CLANG_VERSION_MAJOR)
+       string(REGEX MATCH "^[0-9]+" CLANG_VERSION_MAJOR ${PACKAGE_VERSION})