Skip to content

Commit 2b3657d

Browse files
committed
Numerous CI/CD fixed
1 parent c3b3351 commit 2b3657d

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
# Code quality checks
4747
- name: Check code formatting with Black
4848
run: |
49-
black --check manify --line-length 120/
49+
black --check manify/ --line-length 120
5050
continue-on-error: true
5151

5252
- name: Check import ordering with isort
@@ -63,13 +63,13 @@ jobs:
6363
- name: Check type annotations with MyPy
6464
run: |
6565
# only check core modules—skip untyped imports
66-
mypy --ignore-missing-imports --no-warn-return-any --follow-imports=skip manify
66+
mypy --ignore-missing-imports --no-warn-return-any --follow-imports=skip manify/
6767
continue-on-error: true
6868

6969
# Unit testing
7070
- name: Run unit tests & collect coverage
7171
run: |
72-
pytest tests --cov=manify --cov-report=xml:coverage.xml
72+
pytest tests --cov=manify --cov-report=xml:coverage.xml --cov-fail-under=80
7373
7474
# Code coverage
7575
- name: Upload coverage to Codecov

manify/manifolds.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
from __future__ import annotations
1212

1313
import warnings
14-
from typing import (TYPE_CHECKING, Callable, List, Literal, Optional, Tuple,
15-
Union)
14+
from typing import TYPE_CHECKING, Callable, List, Literal, Optional, Tuple, Union
1615

1716
import geoopt
1817
import torch

manify/utils/benchmarks.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,12 @@
99
from sklearn.base import BaseEstimator
1010
from sklearn.ensemble import RandomForestClassifier, RandomForestRegressor
1111
from sklearn.linear_model import SGDClassifier, SGDRegressor
12-
from sklearn.metrics import (accuracy_score, f1_score, mean_squared_error,
13-
root_mean_squared_error)
12+
from sklearn.metrics import (
13+
accuracy_score,
14+
f1_score,
15+
mean_squared_error,
16+
root_mean_squared_error,
17+
)
1418
from sklearn.model_selection import train_test_split
1519
from sklearn.neighbors import KNeighborsClassifier, KNeighborsRegressor
1620
from sklearn.svm import SVC, SVR

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ dependencies = [
2222

2323
[project.optional-dependencies]
2424
dev = [
25-
"jaxtyping",
25+
"jaxtyping[mypy]",
2626
"beartype",
2727
"pytest",
2828
"mypy",
@@ -81,4 +81,4 @@ packages = ["manify"]
8181
ignore_missing_imports = true
8282

8383
# Use jaxtyping-specific plugins
84-
plugins = ["jaxtyping.mypy_plugin"]
84+
plugins = [ "jaxtyping.mypy_plugin", "beartype.mypy_plugin" ]

0 commit comments

Comments
 (0)