Bug: Incorrect Weekend Handling Causes Undefined Access on Sundays

[ritgit24]

Description

The extension uses Date.getDay() to determine the current day of the week. However, the current weekend check incorrectly handles Sundays, leading to undefined access and background script errors.

In JavaScript:

• getDay() returns 0 for Sunday
• 1–5 for Monday–Friday
• 6 for Saturday

The existing condition:
line 113

if (currentDate.getDay() > 5) {
  return;
}

only excludes Saturday (6) but allows Sunday (0) to pass through.

Due to same error ,
line 68

function setNotification(){
  chrome.storage.local.get(['timetable'], function(result) {
    let currentDate = new Date()
    if(currentDate.getDay() > 5){
      return
    }
    let storedData = result.timetable
    storedData = Convert(storedData)
    let x = storedData[Day(currentDate.getDay()-1)]
    let p = 1
    for(let i=0; i<x.length; i++){
      const ClassTime = new Date(x[i].time)
      title = x[i].title
      if(calculateTimeDifference(ClassTime, 0)){
        p = 0
        if(calculateTimeDifference(ClassTime,0) < 15*60*1000){
          Notify_urgent(ClassTime, title);
          return

an undefined error is thrown in the background for the line
let x = storedData[Day(currentDate.getDay()-1)] as 0 for Sunday is also included(segmentation fault).

[MushMan19]

Hi I'd like to work on solving this issue

The current logic utilizes Date.getDay() which returns 0 for Sunday.
The existing guard clause if (currentDate.getDay() > 5) successfully filters out Saturdays 6 but fails to catch Sundays 0
As a result, the script proceeds to execute:

let x = storedData[Day(currentDate.getDay()-1)]

On Sundays, this evaluates to Day(-1), returning undefined. Trying to access properties of undefined causes the background service worker to throw an error and crash.

Proposed Solution

To update the conditional check in both setNotification() and upcomingClass() functions in background.js to correctly identify weekends.

Current Code:

if (currentDate.getDay() > 5) {
  return;
}

Proposed Change:

Explicitly check for Sunday (0) and Saturday (6)

if (currentDate.getDay() === 0 || currentDate.getDay() === 6) {
  return;
}

This simple fix will prevent the extension from crashing every Sunday and preventing the undefined errors that show up in the error logs.

[this-is-mjk]

@MushMan19 its great to see your approach, and yes its perfect, but @PrakharG8651 has already solved the issues and made a Pull request.

You can look into more issues. Great to see your interest.

[PrakharG8651]

Proposed Solution

The solution is simple as we just modifying the if condition from current.getDay()>5 to currentDate.getDay() > 5 || currentDate.getDay() == 0 .