Bug: Incorrect Parsing of Classes on Tuesday for Certain Weekly Patterns

[ritgit24]

Description

There is an issue in the class-parsing logic where classes scheduled on Tuesday are incorrectly parsed when a course follows a Tuesday and not Thursday schedule.

This issue typically occurs when:

• A course has classes on Tuesday but not on Thursday

For eg. For a course with lectures on Tuesday and Friday , The time Table shows the class to be on Friday only.

As a result, the Tuesday class is either misparsed or omitted during the weekday parsing stage.

---

Expected Behavior

Classes scheduled on Tuesday should be correctly parsed and assigned to Tuesday, regardless of whether the course includes a class on Thursday or any other weekday.

---

Cause

• This fault is not related to data fetching from Pingala
• The data is fetched correctly
• The fault lies in the post-fetch parsing logic, specifically in how classes are mapped or inferred across different weekdays

---

[MushMan19]

Hi, I noticed this bug as well and made a fix in the pr that created for #57
I think the issue lied here:

  // If there is only One T 
  // We have to check for that 
if (count == 1){
  idx = dayString.indexOf('T');
  if (idx == dayString.length - 1) days.push(1);
  else if (dayString[idx + 1] == 'h') {
    days.push(3);
  }
}

This assigns Tuesday if T is the last character. If not, it assigns Thursday if T is followed by h.
This logic breaks if there is a schedule like TF (tuesday and friday), in which case it assigns nothing.

To fix this I simply assign Thursday if T is followed by h and and otherwise assign Tuesday. This works as we only enter this loop once we encounter a T

if (count == 1) {
  idx = dayString.indexOf('T');
  if (dayString[idx + 1] === 'h') {
    days.push(3); // Thursday
  } else {
    days.push(1); // Tuesday
  }
}

[this-is-mjk]

@MushMan19 looks good, but this issue is a bit bigger, it is not just the wrong scheduling, but also the wrong parsing when there are multiple divisions like "Lec: T 10:30-12:00 ,Lec: Th 12:00-13:15 (T111)" only the first Lec is parsed others are not parsed correctly, @ritgit24 was looking into it, if you wish you can also look into it.