Bug: pick/omit labels appear backwards in the interactive rebase levels #1029
annahansen229
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
Yeah thats a good point! Would you like to attempt a fix by submitting a PR? It should be a somewhat easy diff, just a re-order and a logic swap |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
In the interactive rebase levels, the omit/pick labels on the buttons are swapped from what they should be.
I think the intention may have been to label the action that happens when you click the button - i.e., click this to omit it/click this to pick it. But since you are re-creating the appearance of the interactive rebase text editor, it creates confusion because you would expect it to say "pick" next to a commit that you want to keep.
Perhaps a more clear approach to satisfy both labeling the action of the button and accurately representing an interactive rebase text editing session would be to include the 'pick'/'omit' text to the left of the commit ID, then group the drag/drop control and the button together with some visual separation from the text.
Beta Was this translation helpful? Give feedback.
All reactions