comments

Author: pcrespov

services/web/server/src/simcore_service_webserver/api_keys/_controller/rpc.py

@@ -70,4 +70,5 @@ async def delete_api_key_by_key(
 
 async def register_rpc_routes_on_startup(app: web.Application):
     rpc_server = get_rabbitmq_rpc_server(app)
+    # FIXME: should depend on the webserver instance!
     await rpc_server.register_router(router, WEBSERVER_RPC_NAMESPACE, app)

services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rpc.py

@@ -605,6 +605,7 @@ async def get_functions_user_api_access_rights(
 
 async def register_rpc_routes_on_startup(app: web.Application):
     rpc_server = get_rabbitmq_rpc_server(app)
+    # FIXME: should depend on the webserver instance!
     await rpc_server.register_router(router, WEBSERVER_RPC_NAMESPACE, app)
 
 

services/web/server/src/simcore_service_webserver/licenses/_rpc.py

@@ -163,4 +163,5 @@ async def release_licensed_item_for_wallet(
 
 async def register_rpc_routes_on_startup(app: web.Application):
     rpc_server = get_rabbitmq_rpc_server(app)
+    # FIXME: should depend on the webserver instance!
     await rpc_server.register_router(router, WEBSERVER_RPC_NAMESPACE, app)

services/web/server/src/simcore_service_webserver/payments/_rpc_invoice.py

@@ -49,4 +49,5 @@ async def get_invoice_data(
 
 async def register_rpc_routes_on_startup(app: web.Application):
     rpc_server = get_rabbitmq_rpc_server(app)
+    # FIXME: should depend on the webserver instance!
     await rpc_server.register_router(router, WEBSERVER_RPC_NAMESPACE, app)

services/web/server/src/simcore_service_webserver/products/_controller/rpc.py

@@ -29,6 +29,7 @@ async def get_credit_amount(
 
 async def _register_rpc_routes_on_startup(app: web.Application):
     rpc_server = get_rabbitmq_rpc_server(app)
+    # FIXME: should depend on the webserver instance!
     await rpc_server.register_router(router, WEBSERVER_RPC_NAMESPACE, app)
 
 

services/web/server/src/simcore_service_webserver/projects/_controller/projects_rpc.py

@@ -159,4 +159,5 @@ async def get_project_marked_as_job(
 
 async def register_rpc_routes_on_startup(app: web.Application):
     rpc_server = get_rabbitmq_rpc_server(app)
+    # FIXME: should depend on the webserver instance!
     await rpc_server.register_router(router, WEBSERVER_RPC_NAMESPACE, app)

services/web/server/tests/unit/with_dbs/04/products/test_products_rpc.py

@@ -69,6 +69,7 @@ async def test_get_credit_amount(
     osparc_product_name: ProductName,
     logged_user: UserInfoDict,
 ):
+    # FIXME: use client instead here!
     result = await rpc_client.request(
         WEBSERVER_RPC_NAMESPACE,
         TypeAdapter(RPCMethodName).validate_python("get_credit_amount"),