refactor: remove ts-results dependency, use native error handling

Author: pd4d10

package.json

@@ -68,7 +68,6 @@
     "redux": "^5.0.1",
     "tailwind-merge": "^3.3.1",
     "tailwindcss": "^4.1.16",
-    "ts-results": "^3.3.0",
     "tsx": "^4.20.6",
     "typescript": "^5.9.3",
     "universal-analytics": "^0.5.3",

src/main/actions.ts

@@ -29,13 +29,15 @@ export const init: ThunkActionCreator = () => async (dispatch, getState) => {
     // Discover apps for this target
     const target = targetRegistry.getById(targetInfo.id);
     if (target) {
-      const appsResult = await target.discoverApps();
-      if (appsResult.ok) {
+      try {
+        const apps = await target.discoverApps();
         dispatch(targetSlice.actions.appsUpdated({
           targetId: target.id,
-          apps: appsResult.val,
+          apps,
         }));
         dispatch(targetSlice.actions.discoveryCompleted(target.id));
+      } catch (error) {
+        console.error(`Failed to discover apps for ${target.id}:`, error);
       }
     }
   }
@@ -88,13 +90,7 @@ export const debug: ThunkActionCreator<{ targetId: string; app: AppInfo }>
       }
 
       // Launch the app using the target adapter
-      const connectionResult = await target.launch(app, {});
-
-      if (!connectionResult.ok) {
-        throw connectionResult.val;
-      }
-
-      const connection = connectionResult.val;
+      const connection = await target.launch(app, {});
       const sessionId = connection.connectionId;
 
       // Determine connection type
@@ -160,13 +156,7 @@ export const debugPath: ThunkActionCreator<string> = () => async () => {
 export const addRemoteDevice: ThunkActionCreator<RemoteDeviceOptions>
   = (options) => async (dispatch) => {
     try {
-      const targetResult = await targetRegistry.addRemoteDevice(options);
-
-      if (!targetResult.ok) {
-        throw targetResult.val;
-      }
-
-      const target = targetResult.val;
+      const target = await targetRegistry.addRemoteDevice(options);
 
       // Register target in Redux store
       dispatch(
@@ -180,13 +170,15 @@ export const addRemoteDevice: ThunkActionCreator<RemoteDeviceOptions>
       );
 
       // Discover apps from the new target
-      const appsResult = await target.discoverApps();
-      if (appsResult.ok) {
+      try {
+        const apps = await target.discoverApps();
         dispatch(targetSlice.actions.appsUpdated({
           targetId: target.id,
-          apps: appsResult.val,
+          apps,
         }));
         dispatch(targetSlice.actions.discoveryCompleted(target.id));
+      } catch (error) {
+        console.error(`Failed to discover apps for ${target.id}:`, error);
       }
 
       void dialog.showMessageBox({
@@ -221,14 +213,12 @@ export const refreshDeviceApps: ThunkActionCreator<string> = (targetId) => async
     }
 
     // Discover apps from the target
-    const appsResult = await target.discoverApps();
-    if (appsResult.ok) {
-      dispatch(targetSlice.actions.appsUpdated({
-        targetId,
-        apps: appsResult.val,
-      }));
-      dispatch(targetSlice.actions.discoveryCompleted(targetId));
-    }
+    const apps = await target.discoverApps();
+    dispatch(targetSlice.actions.appsUpdated({
+      targetId,
+      apps,
+    }));
+    dispatch(targetSlice.actions.discoveryCompleted(targetId));
   } catch (error) {
     const errorMessage = error instanceof Error ? error.message : String(error);
     dialog.showErrorBox("Refresh Device Error", errorMessage);

src/main/targets/local/adapter.ts

@@ -2,7 +2,6 @@ import { spawn } from "child_process";
 import path from "node:path";
 
 import getPort from "get-port";
-import { Result } from "ts-results";
 import { v4 } from "uuid";
 
 import type { AppInfo } from "../../../reducers/target";
@@ -33,67 +32,57 @@ export class LocalTargetAdapter implements TargetAdapter {
     }
   }
 
-  async discoverApps(): Promise<Result<AppInfo[], Error>> {
-    return Result.wrapAsync(async () => {
-      const { adapter } = await importByPlatform();
-      const result = await adapter.readAll();
-
-      if (!result.ok) {
-        throw result.val;
-      }
-
-      const apps = result.val;
-
-      // Return apps with metadata (device context is added by caller)
-      return apps.map((app) => ({
-        ...app,
-        metadata: {
-          platform: process.platform,
-        },
-      }));
-    });
+  async discoverApps(): Promise<AppInfo[]> {
+    const { adapter } = await importByPlatform();
+    const apps = await adapter.readAll();
+
+    // Return apps with metadata (device context is added by caller)
+    return apps.map((app) => ({
+      ...app,
+      metadata: {
+        platform: process.platform,
+      },
+    }));
   }
 
   async launch(
     app: AppInfo,
     options: LaunchOptions = {},
-  ): Promise<Result<DebugConnection, Error>> {
-    return Result.wrapAsync(async () => {
-      if (!app.exePath) {
-        throw new Error("App does not have an executable path");
-      }
-
-      const nodePort = await getPort();
-      const windowPort = await getPort();
-
-      const debugFlags = options.debugFlags ?? [
-        `--inspect=${nodePort}`,
-        `--remote-debugging-port=${windowPort}`,
-        "--remote-allow-origins=devtools://devtools",
-      ];
-
-      const sp = spawn(app.exePath, debugFlags, {
-        cwd: options.cwd ?? (process.platform === "win32" ? path.dirname(app.exePath) : "/"),
-        env: options.env,
-      });
-
-      const connectionId = v4();
-
-      const connection: DebugConnection = {
-        connectionId,
-        debugPorts: {
-          node: nodePort,
-          renderer: windowPort,
-        },
-        processHandle: sp,
-        cleanup: () => {
-          sp.kill();
-          return Promise.resolve();
-        },
-      };
-
-      return connection;
+  ): Promise<DebugConnection> {
+    if (!app.exePath) {
+      throw new Error("App does not have an executable path");
+    }
+
+    const nodePort = await getPort();
+    const windowPort = await getPort();
+
+    const debugFlags = options.debugFlags ?? [
+      `--inspect=${nodePort}`,
+      `--remote-debugging-port=${windowPort}`,
+      "--remote-allow-origins=devtools://devtools",
+    ];
+
+    const sp = spawn(app.exePath, debugFlags, {
+      cwd: options.cwd ?? (process.platform === "win32" ? path.dirname(app.exePath) : "/"),
+      env: options.env,
     });
+
+    const connectionId = v4();
+
+    const connection: DebugConnection = {
+      connectionId,
+      debugPorts: {
+        node: nodePort,
+        renderer: windowPort,
+      },
+      processHandle: sp,
+      cleanup: () => {
+        sp.kill();
+        return Promise.resolve();
+      },
+    };
+
+    return connection;
   }
 
   async disconnect(): Promise<void> {