Check instance support failed without resolving (#26)

Author: ovkireev

src/Job/QlessJob.php

@@ -208,7 +208,8 @@ protected function failed($e)
 
         [$class, $method] = JobName::parse($payload['job']);
 
-        if (class_exists($class) && method_exists($this->instance = $this->resolve($class), 'failed')) {
+        if (class_exists($class) && method_exists($class, 'failed')) {
+            $this->instance = $this->resolve($class);
             $this->instance->failed($payload['data'], $e);
         }
     }

tests/Job/QlessJobTest.php

@@ -8,6 +8,7 @@
 use LaravelQless\Queue\QlessQueue;
 use LaravelQless\Tests\Helpers\ModifierTrait;
 use LaravelQless\Tests\Stub\JobStub;
+use LaravelQless\Tests\Stub\JobWithOutFailedStub;
 use Orchestra\Testbench\TestCase;
 use LaravelQless\Job\QlessJob;
 use Qless\Jobs\BaseJob;
@@ -98,6 +99,28 @@ public function testFireFailedWithExistentClass(): void
         self::assertNotNull($job->getResolvedJob());
     }
 
+    public function testFireWithNonFailedClass(): void
+    {
+        $jobMock = $this->getJob();
+        $jobMock->method('getData')
+            ->willReturn(new JobData(['key' => 'value']));
+
+        $jobMock->method('__get')
+            ->with('failed')
+            ->willReturn(true);
+
+        $container = $this->getContainer();
+        $container->expects(self::never())->method('make')->with(JobWithOutFailedStub::class)
+            ->willReturn(new JobWithOutFailedStub());
+
+        $payload = json_encode(['job' => JobWithOutFailedStub::class . '@failed', 'data' => []]);
+
+        $job = (new QlessJob($container, $this->getQueue(), $this->getJobHandler(), $jobMock, $payload));
+        $job->fire();
+
+        self::assertNull($job->getResolvedJob());
+    }
+
     public function testRelease(): void
     {
         $queue = $this->getQueue();

tests/Stub/JobWithOutFailedStub.php

@@ -0,0 +1,14 @@
+<?php
+namespace LaravelQless\Tests\Stub;
+
+/**
+ * Class JobWithOutFailedStub
+ * 
+ * @package LaravelQless\Tests\Stub
+ */
+class JobWithOutFailedStub
+{
+    public function fire()
+    {
+    }
+}