Replies: 1 comment
-
PR welcomed. Regarding this:
Since the config values for these two items are both True, we don't need to bother with the details. Instead, one sentence is fine:
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
The CONTRIBUTING docs tell to install dependencies in a venv (not showing how to actually create one) with this:
But that doesn't actually install the dev-dependencies.
So the next command fails:
pdm run test
.It should say "must" and not "may", as this is clearly required. Showing how to do so would be nice as well:
Then, the docs should say to install the dev-deps with
pdm install
.So, in the end:
Or just this if PDM and pre-commit are already installed:
Beta Was this translation helpful? Give feedback.
All reactions