get user from session, prevent double start session

Author: ylebre

lib/Api/Solid.php

@@ -4,6 +4,7 @@
         use Pdsinterop\PhpSolid\Server;
         use Pdsinterop\PhpSolid\ClientRegistration;
         use Pdsinterop\PhpSolid\User;
+        use Pdsinterop\PhpSolid\Session;
 
 	class Solid {
 		public static function respondToJwks() {
@@ -19,6 +20,8 @@ public static function respondToWellKnownOpenIdConfiguration() {
 		}
 
 		public static function respondToAuthorize() {
+			$user = User::getUser(Session::getLoggedInUser());
+
 			$clientId = $_GET['client_id'];
 			$getVars = $_GET;
 
@@ -146,6 +149,7 @@ public static function respondToRegister() {
 		}
 
 		public static function respondToSharing() {
+			$user = User::getUser(Session::getLoggedInUser());
 			$clientId = $_POST['client_id'];
 			$userId = $user['userId'];
 			if ($_POST['consent'] === 'true') {

lib/Session.php

@@ -4,14 +4,18 @@
 	class Session {
 		private $cookieLifetime = 24*60*60;
 		public static function start($username) {
-			session_start([
-				'cookie_lifetime' => 24*60*60 // 1 day
-			]);
+			if (session_status() === PHP_SESSION_NONE) {
+				session_start([
+					'cookie_lifetime' => 24*60*60 // 1 day
+				]);
+			}
 			$_SESSION['username'] = $username;
 		}
 
 		public static function getLoggedInUser() {
-			session_start();
+			if (session_status() === PHP_SESSION_NONE) {
+				session_start();
+			}
 			if (!isset($_SESSION['username'])) {
 				return false;
 			}