remove 'tester' from the code. add tester clients as allowed clients in the init.sh script for the test suite instead.

Author: ylebre

init.sh

@@ -6,4 +6,6 @@ php console.php app:enable solid
 php console.php config:system:set trusted_domains 1 --value=server
 php console.php config:system:set trusted_domains 2 --value=nextcloud.local
 php console.php config:system:set trusted_domains 3 --value=thirdparty
+# set 'tester' and 'https://tester' as allowed clients for the test suite to run
+php console.php user:setting alice solid allowedClients '["f5d1278e8109edd94e1e4197e04873b9", "2e5cddcf0f663544e98982931e6cc5a6"]'
 echo configured

solid/lib/Controller/ServerController.php

@@ -255,12 +255,6 @@ public function authorize() {
 
 	private function checkApproval($clientId) {
 		$allowedClients = $this->config->getAllowedClients($this->userId);
-		if ($clientId == md5("tester")) { // FIXME: Double check that this is not a security issue; It is only here to help the test suite;
-			return \Pdsinterop\Solid\Auth\Enum\Authorization::APPROVED;
-		}
-		if ($clientId == md5("https://tester")) { // FIXME: Double check that this is not a security issue; It is only here to help the test suite;
-			return \Pdsinterop\Solid\Auth\Enum\Authorization::APPROVED;
-		}
 		if (in_array($clientId, $allowedClients)) {
 			return \Pdsinterop\Solid\Auth\Enum\Authorization::APPROVED;
 		} else {