Skip to content

Commit 0a5733f

Browse files
committed
Fix broken unit-test.
1 parent 6c86896 commit 0a5733f

File tree

1 file changed

+36
-14
lines changed

1 file changed

+36
-14
lines changed

solid/tests/Unit/Controller/PageControllerTest.php

Lines changed: 36 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,47 @@
11
<?php
22

3-
namespace OCA\Solid\Tests\Unit\Controller;
4-
5-
use PHPUnit_Framework_TestCase;
3+
namespace OCA\Solid\Controller;
64

75
use OCP\AppFramework\Http\TemplateResponse;
8-
9-
use OCA\Solid\Controller\PageController;
10-
11-
12-
class PageControllerTest extends PHPUnit_Framework_TestCase {
6+
use OCP\IConfig;
7+
use OCP\IRequest;
8+
use OCP\IURLGenerator;
9+
use OCP\IUserManager;
10+
use PHPUnit\Framework\TestCase;
11+
12+
/**
13+
* @coversDefaultClass \OCA\Solid\Controller\PageController
14+
* @covers ::__construct
15+
*/
16+
class PageControllerTest extends TestCase
17+
{
18+
private const MOCK_USER_ID = 'mock-user';
1319
private $controller;
14-
private $userId = 'john';
15-
16-
public function setUp() {
17-
$request = $this->getMockBuilder('OCP\IRequest')->getMock();
1820

19-
$this->controller = new PageController('solid', $request, $this->userId);
21+
public function setUp(): void
22+
{
23+
$mockConfig = $this->getMockBuilder(IConfig::class)->getMock();
24+
$mockRequest = $this->getMockBuilder(IRequest::class)->getMock();
25+
$mockUrlGenerator = $this->getMockBuilder(IURLGenerator::class)->getMock();
26+
$mockUserManager = $this->getMockBuilder(IUserManager::class)->getMock();
27+
28+
$this->controller = new PageController(
29+
'solid',
30+
$mockRequest,
31+
$mockConfig,
32+
$mockUserManager,
33+
$mockUrlGenerator,
34+
self::MOCK_USER_ID
35+
);
2036
}
2137

22-
public function testIndex() {
38+
/**
39+
* @covers ::index
40+
* @uses \OCA\Solid\BaseServerConfig::__construct
41+
* @uses \OCA\Solid\ServerConfig::__construct
42+
*/
43+
public function testIndex()
44+
{
2345
$result = $this->controller->index();
2446

2547
$this->assertEquals('index', $result->getTemplateName());

0 commit comments

Comments
 (0)