Skip to content

Commit 8f30461

Browse files
Use latest pubsub and latest test suite
1 parent c88fc9b commit 8f30461

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

run-solid-test-suite.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ set -e
44
function setup {
55
docker network create testnet
66
docker build -t solid-nextcloud .
7-
docker build -t pubsub-server https://github.com/pdsinterop/php-solid-pubsub-server.git#main
7+
docker build -t pubsub-server https://github.com/pdsinterop/php-solid-pubsub-server.git#feature-secure-webhook-to-ws
88
docker pull michielbdejong/nextcloud-cookie
99
docker pull solidtestsuite/webid-provider-tests:v2.1.0
1010
docker tag solidtestsuite/webid-provider-tests:v2.1.0 webid-provider-tests
11-
docker pull solidtestsuite/solid-crud-tests:v7.0.5
12-
docker tag solidtestsuite/solid-crud-tests:v7.0.5 solid-crud-tests
11+
docker pull solidtestsuite/solid-crud-tests:v7.0.6
12+
docker tag solidtestsuite/solid-crud-tests:v7.0.6 solid-crud-tests
1313
docker pull solidtestsuite/web-access-control-tests:v7.1.0
1414
docker tag solidtestsuite/web-access-control-tests:v7.1.0 web-access-control-tests
1515
}

solid/lib/Controller/SolidWebhookController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public function registerWs(string $topic): DataResponse {
9595
// https://www.php.net/manual/en/function.random-bytes.php says it
9696
// generates "cryptographically secure pseudo-random bytes"
9797
$token = bin2hex(random_bytes(20));
98-
$target = "$toPub/$token?" . urlencode($topic);
98+
$target = "$toPub/$token";
9999
if ($this->checkReadAccess($topic)) {
100100
$webhook = $this->webhookService->create($this->webId, $topic, $target);
101101
return new DataResponse([

0 commit comments

Comments
 (0)