Skip to content

Commit 94ef670

Browse files
committed
Change workflow to use branch name for docker tag
This is done for two reasons: 1. To more clearly distinguish the digest from the tag (the former is useful for caching, the latter is not) 2. Using the digest as a tag is overkill, as we only need to keep the newest image for each branch (that way, the docker image follows the HEAD of the branch)
1 parent 81a2b79 commit 94ef670

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ jobs:
4141
- name: Build Solid-Nextcloud Docker image
4242
run: |
4343
docker build \
44-
--tag "solid-nextcloud:${{ github.sha }}" \
45-
--tag "ghcr.io/pdsinterop/solid-nextcloud:${{ github.sha }}" \
44+
--tag "solid-nextcloud:${{ github.ref_name }}" \
45+
--tag "ghcr.io/pdsinterop/solid-nextcloud:${{ github.ref_name }}" \
4646
.
47-
docker push "ghcr.io/pdsinterop/solid-nextcloud:${{ github.sha }}"
47+
docker push "ghcr.io/pdsinterop/solid-nextcloud:${{ github.ref_name }}"
4848
mkdir -p cache/solid-nextcloud
49-
docker image save solid-nextcloud:${{ github.sha }} --output ./cache/solid-nextcloud/${{ github.sha }}.tar
49+
docker image save solid-nextcloud:${{ github.ref_name }} --output ./cache/solid-nextcloud/${{ github.sha }}.tar
5050
5151
solid-testsuite:
5252
strategy:
@@ -95,8 +95,8 @@ jobs:
9595
"ghcr.io/pdsinterop/php-solid-pubsub-server:${{ env.PUBSUB_TAG }}"
9696
9797
source ./run-solid-test-suite.sh
98-
startSolidNextcloud 'server' "solid-nextcloud:${{ github.sha }}" ${{ matrix.test }}
99-
startSolidNextcloud 'thirdparty' "solid-nextcloud:${{ github.sha }}" ${{ matrix.test }}
98+
startSolidNextcloud 'server' "solid-nextcloud:${{ github.ref_name }}" ${{ matrix.test }}
99+
startSolidNextcloud 'thirdparty' "solid-nextcloud:${{ github.ref_name }}" ${{ matrix.test }}
100100
101101
echo "COOKIE_server=${COOKIE_server}" >> "${GITHUB_ENV}"
102102
echo "COOKIE_thirdparty=${COOKIE_thirdparty}" >> "${GITHUB_ENV}"

0 commit comments

Comments
 (0)