Skip to content

Commit 2acc83b

Browse files
committed
Really fix jitpack ignoring signing.
1 parent 6099ee4 commit 2acc83b

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.idea/runConfigurations/xmlutil__check_.xml

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

project-plugins/src/main/kotlin/net/devrieze/gradle/ext/publishing.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import org.gradle.api.publish.maven.tasks.AbstractPublishToMaven
2929
import org.gradle.api.publish.maven.tasks.PublishToMavenRepository
3030
import org.gradle.api.tasks.bundling.Jar
3131
import org.gradle.api.tasks.bundling.Zip
32+
import org.gradle.internal.extensions.core.extra
3233
import org.gradle.kotlin.dsl.*
3334
import org.gradle.plugins.signing.SigningExtension
3435

@@ -73,11 +74,11 @@ fun Project.doPublish(
7374
priv_key != null && passphrase != null -> useInMemoryPgpKeys(priv_key, passphrase)
7475

7576
System.getenv("JITPACK").equals("true", true) -> {
76-
if (!rootProject.hasProperty("NO_SIGNING")) {
77+
if (!rootProject.extra.has("NO_SIGNING")) {
7778
logger.warn("No private key information found in environment. Running on Jitpack, skipping signing")
7879

7980
setRequired(false)
80-
rootProject.setProperty("NO_SIGNING", true)
81+
rootProject.extra.set("NO_SIGNING", true)
8182
}
8283
}
8384

@@ -130,7 +131,7 @@ fun Project.doPublish(
130131

131132
configure<SigningExtension> {
132133
when {
133-
rootProject.findProperty("NO_SIGNING") == true ->
134+
rootProject.extra["NO_SIGNING"] == true ->
134135
setRequired(false)
135136

136137
else ->

0 commit comments

Comments
 (0)