enhance question output

Author: peanut996

components/question-area.tsx

@@ -1,11 +1,9 @@
 "use client";
 
 import { Badge } from "@/components/ui/badge";
-import { Button } from "@/components/ui/button";
 import { Card, CardContent } from "@/components/ui/card";
 import type { Question } from "@/lib/types";
 import { useTranslation } from "@/lib/i18n";
-import { cleanupTestCase } from "@/lib/utils";
 import ReactMarkdown from "react-markdown";
 import remarkGfm from "remark-gfm";
 import rehypeRaw from "rehype-raw";
@@ -31,14 +29,6 @@ export default function QuestionArea({
   const topic =
     question.translations[language]?.topic || question.translations.en.topic;
 
-  // 移除不必要的 \n 到 <br> 转换，让 Markdown 处理换行
-  // const correctedDescription = description.replace(/\n/g, "<br>");
-  
-  // 处理转义引号问题
-  const correctedDescription = description
-    .replace(/\\"/g, '"')  // 将 \" 转换为 "
-    .replace(/\\'/g, "'"); // 将 \' 转换为 '
-
   return (
     <Card className="mb-6 shadow-sm border border-gray-200 dark:border-gray-800 bg-white dark:bg-[#2c2c2e] rounded-xl">
       <CardContent className="p-6">
@@ -75,7 +65,7 @@ export default function QuestionArea({
             remarkPlugins={[remarkGfm]}
             rehypePlugins={[rehypeRaw]}
           >
-            {correctedDescription}
+            {description}
           </ReactMarkdown>
 
           {question.type === "Coding" && question.testCases && (
@@ -91,11 +81,11 @@ export default function QuestionArea({
                   >
                     <div>
                       <strong>{t("question.input")}:</strong>{" "}
-                      {cleanupTestCase(testCase.input)}
+                      {testCase.input}
                     </div>
                     <div>
                       <strong>{t("question.output")}:</strong>{" "}
-                      {cleanupTestCase(testCase.output)}
+                      {testCase.output}
                     </div>
                   </div>
                 ))}

lib/api.ts

@@ -260,6 +260,17 @@ export async function generateQuestion(type: string, category: string, difficult
   The response MUST be directly parseable as JSON without any cleanup needed.
   Ensure all special characters in strings are properly escaped according to JSON standards.
   
+  When creating coding questions with test cases, format the input as a plain string rather than a JSON object.
+  For example, use 'a = "helloworld", b = "world"' rather than {a: "helloworld", b: "world"}.
+  
+  IMPORTANT: If a test case output is a string, you MUST enclose it in additional double quotes and escape them properly in JSON.
+  For example: 
+  - For string output "hello": { "input": "some input", "output": "\"hello\"" }
+  - For empty string: { "input": "some input", "output": "\"\"" }
+  - For numbers: { "input": "some input", "output": "42" } (no extra quotes for numbers)
+  
+  DO NOT leave string outputs without proper double quotes. Only add the extra quotes for string outputs, not for numbers or other types.
+  
   Return your response in JSON format exactly matching the structure provided, with no additional text.`;
 
   const prompt = `
@@ -287,19 +298,37 @@ export async function generateQuestion(type: string, category: string, difficult
       }
     }${type === 'Coding' ? `,
     "testCases": [
-      { "input": "example input 1", "output": "expected output 1" },
-      { "input": "example input 2", "output": "expected output 2" }
+      { "input": "a = \"helloworld\", b = \"world\"", "output": "\"world\"" },
+      {"input": "a = \"programming\", b = \"prog\"", "output": "\"prog\"" },
+      { "input": "x = 5, y = 10", "output": "50" },
+      { "input": "str = \"\"", "output": "\"\"" },
+      { "input": "", "output": "\"\"" }
     ]` : ''}
   }
   
   Make sure the question is appropriate for the difficulty level and incorporates concepts from all the specified categories.
   If multiple categories are provided, create a question that combines elements from these categories.
+  
+  IMPORTANT: For test cases where the output is a string, ALWAYS enclose the output in additional double quotes:
+  - For string output: "output": "\"hello\""
+  - For empty string: "output": "\"\""
+  - For number output: "output": "42" (no extra quotes for numbers)
+  
+  Pay careful attention to the data type of the expected output and format it accordingly.
   `
 
   try {
     const result = await callOpenAI(prompt, systemPrompt, (_) => {}, "question")
-
-    return JSON.parse(jsonrepair(result))
+    
+    // Preprocess the JSON to handle incorrectly formatted empty strings
+    const preprocessedResult = result
+      // Replace four consecutive double quotes """" with the properly escaped empty string "\"\""
+      .replace(/""""/g, "\"\\\"\\\"\"")
+      // Replace two consecutive double quotes "" with the properly escaped empty string "\"\""
+      // But avoid replacing already properly escaped empty strings "\"\"" 
+      .replace(/(?<!\\)""/g, "\"\\\"\\\"\"");
+
+    return JSON.parse(jsonrepair(preprocessedResult))
   } catch (error) {
     console.error("Error generating question:", error)
     throw new Error("Failed to generate question. Please check your API settings and try again.")

lib/utils.ts

@@ -43,31 +43,6 @@ export function encodeCodeBlocks(text: string): string {
   return processAnswerWithRegexImproved(text)
 }
 
-// Function to clean up test case displays by removing extra quotes
-export function cleanupTestCase(value: any): string {
-  if (typeof value !== 'string') {
-    return JSON.stringify(value);
-  }
-  
-  // 先尝试直接处理转义引号
-  let cleanedValue = value.replace(/\\"/g, '"').replace(/\\'/g, "'");
-  
-  // 如果字符串以引号开始和结束，可能是 JSON 字符串
-  if ((cleanedValue.startsWith('"') && cleanedValue.endsWith('"')) || 
-      (cleanedValue.startsWith("'") && cleanedValue.endsWith("'"))) {
-    try {
-      // Try to parse the JSON string to get the actual value
-      const parsed = JSON.parse(cleanedValue);
-      return typeof parsed === 'string' ? parsed : JSON.stringify(parsed);
-    } catch (e) {
-      // If parsing fails, return the cleaned value
-      return cleanedValue;
-    }
-  }
-  
-  return cleanedValue;
-}
-
 // Function to format code blocks for display
 export function formatCodeBlock(codeText: string): { code: string; language: string } {
   // Default values