Skip to content

Conversation

@pynappo
Copy link
Contributor

@pynappo pynappo commented Jul 28, 2025

Related to: #3316, #3368

Discord has now made the API public for changing which activity field is featured in the status (as well as allowing each field of the activity to embed separate URLs).

The main thing is that we can now set the status to Listening to {artist name} and Listening to {song title}.

This PR:

  • implements a configurable option for this
  • sets the new default to be Listening to {artist name} (since it aligns w/ Spotify)
  • also embeds the song url into the title
image image

Note

Feel free to comment on how the option menu labels are worded, i'm not sure if it's clear/intuitive.

@pynappo pynappo force-pushed the listening-to-artist branch from 24c47f2 to d363db1 Compare July 28, 2025 09:11
@pynappo pynappo force-pushed the listening-to-artist branch from d363db1 to eb2b12b Compare July 28, 2025 09:18
@JellyBrick JellyBrick requested a review from Copilot July 28, 2025 14:04
@JellyBrick JellyBrick added the enhancement New feature or request label Jul 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a configurable option to control how the Discord Rich Presence status text is displayed, allowing users to choose between "Listening to YouTube Music", "Listening to {artist}", or "Listening to {song title}". The default is changed to display the artist name to align with Spotify's behavior.

  • Implements a new statusDisplayType configuration option with three display modes
  • Updates the Discord RPC library to version 1.3.0 to support the new status display API
  • Adds a menu interface for users to select their preferred status display type

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/plugins/discord/constants.ts Defines the DiscordStatusDisplayType enum for status display options
src/plugins/discord/index.ts Adds statusDisplayType to plugin config with ARTIST as default
src/plugins/discord/menu.ts Implements radio button menu for selecting status display type
src/plugins/discord/discord-service.ts Passes statusDisplayType and detailsUrl to Discord activity
src/i18n/resources/en.json Adds localization strings for the new menu options
package.json Updates @xhayper/discord-rpc to version 1.3.0
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@ArjixWasTaken
Copy link
Member

Looks like it's so new, that it's not added to the discordjs types yet.
discordjs/discord-api-types#1306

@pynappo pynappo changed the title feat(discord): option to display artist/title in status feat(discord): add option to display artist/title in status Jul 29, 2025
foxfirecodes added a commit to foxfirecodes/youtube-music that referenced this pull request Aug 10, 2025
@foxfirecodes
Copy link
Contributor

foxfirecodes commented Aug 10, 2025

hey there, dev who built these features for rich presence here :3 while StatusDisplayType hasnt been added to discord-api-types, it is available as an enum in the @xhayper/discord-rpc lib you're using. is there a reason to block this on being added to discord-api-types? it doesnt even make sense to me to use discord-api-types here since you're not using the rest api, you're using the rpc api (i'm aware they include rpc types, but id think you'd want to use the types from the rpc lib you're using, since that more accurately mirrors what the rpc lib is capable of)

@ArjixWasTaken
Copy link
Member

@foxfirecodes

I don't think this PR is "blocked" in that sense, it just hasn't been merged yet.

Jellybrick usually merges PRs whenever he wants to make a new release, I assume that's the case here

@JellyBrick JellyBrick merged commit 8e4e2c4 into pear-devs:master Sep 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants