-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(discord): add option to display artist/title in status #3692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
24c47f2 to
d363db1
Compare
d363db1 to
eb2b12b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a configurable option to control how the Discord Rich Presence status text is displayed, allowing users to choose between "Listening to YouTube Music", "Listening to {artist}", or "Listening to {song title}". The default is changed to display the artist name to align with Spotify's behavior.
- Implements a new
statusDisplayTypeconfiguration option with three display modes - Updates the Discord RPC library to version 1.3.0 to support the new status display API
- Adds a menu interface for users to select their preferred status display type
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/discord/constants.ts | Defines the DiscordStatusDisplayType enum for status display options |
| src/plugins/discord/index.ts | Adds statusDisplayType to plugin config with ARTIST as default |
| src/plugins/discord/menu.ts | Implements radio button menu for selecting status display type |
| src/plugins/discord/discord-service.ts | Passes statusDisplayType and detailsUrl to Discord activity |
| src/i18n/resources/en.json | Adds localization strings for the new menu options |
| package.json | Updates @xhayper/discord-rpc to version 1.3.0 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Looks like it's so new, that it's not added to the discordjs types yet. |
|
hey there, dev who built these features for rich presence here :3 while StatusDisplayType hasnt been added to discord-api-types, it is available as an enum in the |
|
I don't think this PR is "blocked" in that sense, it just hasn't been merged yet. Jellybrick usually merges PRs whenever he wants to make a new release, I assume that's the case here |
Related to: #3316, #3368
Discord has now made the API public for changing which activity field is featured in the status (as well as allowing each field of the activity to embed separate URLs).
The main thing is that we can now set the status to
Listening to {artist name}andListening to {song title}.This PR:
Listening to {artist name}(since it aligns w/ Spotify)Note
Feel free to comment on how the option menu labels are worded, i'm not sure if it's clear/intuitive.