Skip to content

Conversation

@foxfirecodes
Copy link
Contributor

@foxfirecodes foxfirecodes commented Aug 10, 2025

hey there, dev who implemented the new rich presence fields here :3

this pr adds clickable artist & song links to the rich presence. i looked through the payload to see if there's a good way to get the album URL, but i couldn't find a field that is reliable. i thought maybe playlistId would work, but when listening to a playlist its the id of the playlist the song is part of rather than the album.

i originally also added a statusDisplayType of STATE to align it with how Spotify rich presence works by default, but i saw there is a much more comprehensive PR open at #3692

Screencast_20250810_084314.webm

Comment on lines 112 to 114
activityInfo.largeImageText = '⏸';
activityInfo.largeImageText = '⏸';

This comment was marked as resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure why my editor insisted on changing that when i saved, but just in case there was some significance to the zero width char ive reverted that one line

Copy link
Member

@ArjixWasTaken ArjixWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@JellyBrick JellyBrick requested a review from Copilot August 17, 2025 13:52
@JellyBrick JellyBrick added the enhancement New feature or request label Aug 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements clickable song and artist links in Discord's rich presence feature by leveraging Discord's new rich presence fields. The changes add URL fields to the song information structure and populate them with appropriate YouTube Music links for songs and artists.

  • Adds artistUrl field to the SongInfo interface and populates it with the artist's YouTube Music channel URL
  • Updates Discord service to include clickable URLs for both song details and artist state in the rich presence
  • Minor cleanup of album assignment code structure

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/providers/song-info.ts Adds artistUrl field to SongInfo interface and populates it from microformat data
src/plugins/discord/discord-service.ts Integrates song and artist URLs into Discord rich presence activity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JellyBrick JellyBrick merged commit e6c78dd into pear-devs:master Sep 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants