-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(discord): add song & artist URLs to rich presence #3737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(discord): add song & artist URLs to rich presence #3737
Conversation
| activityInfo.largeImageText = '⏸︎'; | ||
| activityInfo.largeImageText = '⏸'; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure why my editor insisted on changing that when i saved, but just in case there was some significance to the zero width char ive reverted that one line
ArjixWasTaken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements clickable song and artist links in Discord's rich presence feature by leveraging Discord's new rich presence fields. The changes add URL fields to the song information structure and populate them with appropriate YouTube Music links for songs and artists.
- Adds
artistUrlfield to theSongInfointerface and populates it with the artist's YouTube Music channel URL - Updates Discord service to include clickable URLs for both song details and artist state in the rich presence
- Minor cleanup of album assignment code structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/providers/song-info.ts | Adds artistUrl field to SongInfo interface and populates it from microformat data |
| src/plugins/discord/discord-service.ts | Integrates song and artist URLs into Discord rich presence activity |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: JellyBrick <[email protected]>
hey there, dev who implemented the new rich presence fields here :3
this pr adds clickable artist & song links to the rich presence. i looked through the payload to see if there's a good way to get the album URL, but i couldn't find a field that is reliable. i thought maybe playlistId would work, but when listening to a playlist its the id of the playlist the song is part of rather than the album.
i originally also added a statusDisplayType of STATE to align it with how Spotify rich presence works by default, but i saw there is a much more comprehensive PR open at #3692
Screencast_20250810_084314.webm