Commit 5e7ede3
authored
Handle OpenPGP-compliant CSF message verfication (#40)
GnuPG has traditionally emitted a spurious newline when outputting the
text verified from a cleartext signing framework message, if the
signed message doesn't contain a trailing newline.
This is clearly wrong according to the OpenPGP specification, which
says:
> The line ending (i.e., the <CR><LF>) before the '-----BEGIN PGP
> SIGNATURE-----' line that terminates the signed text is not
> considered part of the signed text.
The test in Crypt_GPG presumes that the trailing newline is returned,
as that has been traditional GnuPG (mis)behavior.
This change adjusts the test suite so that it passes regardless of
whether GnuPG conforms to the specification or misbehaves in the
traditional way.
See https://dev.gnupg.org/T7106 for discussion with upstream.
See also https://gitlab.com/freepg/gnupg/-/merge_requests/15, where
the FreePG project is bringing a patched version of GnuPG into
compliance with the specification.
Finally, please also see the discussion over on
https://bugs.debian.org/1099043 -- debian's GnuPG is being brought
into compliance with the OpenPGP standard for CSF messages, so we need
something like this to ensure that the Crypt_GPG test suite succeeds.1 parent e0799f5 commit 5e7ede3
2 files changed
+7
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
939 | 939 | | |
940 | 940 | | |
941 | 941 | | |
942 | | - | |
| 942 | + | |
943 | 943 | | |
944 | 944 | | |
945 | 945 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
634 | 634 | | |
635 | 635 | | |
636 | 636 | | |
637 | | - | |
| 637 | + | |
638 | 638 | | |
639 | 639 | | |
640 | 640 | | |
| |||
666 | 666 | | |
667 | 667 | | |
668 | 668 | | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
669 | 674 | | |
670 | 675 | | |
671 | 676 | | |
| |||
0 commit comments