experiment: enable retrieving full Wikipedia articles

Signed-off-by: Katharine Berry <[email protected]>

Author: Katharine

service/assistant/functions/functions.go

@@ -91,9 +91,9 @@ func CallFunction(ctx context.Context, qt *quota.Tracker, fn, args string) (stri
 	if err != nil {
 		return "", fmt.Errorf("unable to marshal response: %v", err)
 	}
-	if len(r) > MaxResponseSize {
-		r = r[:MaxResponseSize]
-	}
+	//if len(r) > MaxResponseSize {
+	//	r = r[:MaxResponseSize]
+	//}
 	return string(r), nil
 }
 
@@ -169,9 +169,9 @@ func CallAction(ctx context.Context, qt *quota.Tracker, fn, args string, ws *web
 	if err != nil {
 		return "", fmt.Errorf("unable to marshal response: %v", err)
 	}
-	if len(r) > MaxResponseSize {
-		r = r[:MaxResponseSize]
-	}
+	//if len(r) > MaxResponseSize {
+	//	r = r[:MaxResponseSize]
+	//}
 	return string(r), nil
 }
 

service/assistant/functions/wikipedia.go

@@ -31,7 +31,8 @@ import (
 )
 
 type WikipediaRequest struct {
-	Query string `json:"article_name"`
+	Query           string `json:"article_name"`
+	CompleteArticle bool   `json:"complete_article"`
 }
 
 type WikipediaResponse struct {
@@ -42,7 +43,7 @@ func init() {
 	registerFunction(Registration{
 		Definition: genai.FunctionDeclaration{
 			Name:        "wikipedia",
-			Description: "Look up the content of a single named English Wikipedia page.",
+			Description: "Look up the content of a single named English Wikipedia page. Never say the Wikipedia page didn't have the information needed without first trying to fetch the complete article.",
 			Parameters: &genai.Schema{
 				Type:     genai.TypeObject,
 				Nullable: false,
@@ -52,6 +53,11 @@ func init() {
 						Description: "The name of the English Wikipedia page to look up",
 						Nullable:    false,
 					},
+					"complete_article": {
+						Type:        genai.TypeBoolean,
+						Description: "Whether to return the complete article or just the summary. Prefer to fetch only the summary. If the summary didn't have the information you expected, you can try again with the complete article.",
+						Nullable:    false,
+					},
 				},
 				Required: []string{"article_name"},
 			},
@@ -68,7 +74,7 @@ func queryWikipediaThought(args interface{}) string {
 
 func queryWikipedia(ctx context.Context, quotaTracker *quota.Tracker, args interface{}) interface{} {
 	req := args.(*WikipediaRequest)
-	results, err := queryWikipediaInternal(ctx, req.Query, true)
+	results, err := queryWikipediaInternal(ctx, req.Query, req.CompleteArticle, true)
 	if err != nil {
 		return Error{Error: err.Error()}
 	}
@@ -77,13 +83,17 @@ func queryWikipedia(ctx context.Context, quotaTracker *quota.Tracker, args inter
 	}
 }
 
-func queryWikipediaInternal(ctx context.Context, query string, allowSearch bool) (string, error) {
+func queryWikipediaInternal(ctx context.Context, query string, completeArticle, allowSearch bool) (string, error) {
 	ctx, span := beeline.StartSpan(ctx, "query_wikipedia")
 	defer span.Send()
 	span.AddField("title", query)
-	log.Printf("Looking up Wikipedia article: %q\n", query)
+	log.Printf("Looking up Wikipedia article: %q (complete: %t)\n", query, completeArticle)
 	qs := url.QueryEscape(query)
-	request, err := http.NewRequestWithContext(ctx, "GET", "https://en.wikipedia.org/w/api.php?action=query&prop=revisions&rvprop=content&format=xml&titles="+qs+"&rvsection=0&rvslots=main", nil)
+	url := "https://en.wikipedia.org/w/api.php?action=query&prop=revisions&rvprop=content&format=xml&titles=" + qs + "&rvslots=main"
+	if !completeArticle {
+		url += "&rvsection=0"
+	}
+	request, err := http.NewRequestWithContext(ctx, "GET", url, nil)
 	if err != nil {
 		return "", err
 	}
@@ -116,9 +126,13 @@ func queryWikipediaInternal(ctx context.Context, query string, allowSearch bool)
 		if len(searchResult) == 0 {
 			return "", errors.New("Wikipedia page not found. Try to answer using your general knowledge.")
 		}
-		return queryWikipediaInternal(ctx, searchResult[0], false)
+		return queryWikipediaInternal(ctx, searchResult[0], completeArticle, false)
+	}
+	addendum := ""
+	if !completeArticle {
+		addendum = "\n\nThis was only the summary. If necessary, more information can be returned by repeating the query_wikipedia call with complete_article = true. You can always do this automatically, without prompting the user."
 	}
-	return string(content), nil
+	return string(content) + addendum, nil
 }
 
 func searchWikipedia(ctx context.Context, query string) ([]string, error) {

service/assistant/system_prompt.go

@@ -95,7 +95,7 @@ func (ps *PromptSession) generateSystemPrompt(ctx context.Context) string {
 		"Your name is Bobby, and you are running on a Pebble smartwatch. " +
 		"The text you receive is transcribed from voice input. " +
 		"Your knowledge cutoff is September 2024. However, you can use the wikipedia function to access the current content of specific Wikipedia pages. " +
-		"Always follow Wikipedia redirects immediately and silently. Never ask the user whether you should check wikipedia - if you would ask, assume that you should. Don't mention looking up articles or Wikipedia to the user. " +
+		"Always follow Wikipedia redirects immediately and silently. Never ask the user whether you should check wikipedia, or whether you should check the full article - if you would ask, assume that you should (but don't ever fetch full articles if you already have the answer to the question). Don't mention looking up articles or Wikipedia to the user. " +
 		locationString +
 		ps.generateTimeSentence(ctx) +
 		"You may call multiple functions before responding to the user, if necessary. If executing a lua script fails, try hard to fix the script using the error message, and consider alternate approaches to solve the problem. " +