Skip to content

Commit 0c1ffdb

Browse files
authored
Merge pull request #315 from WhosNickDoglio/ndoglio/verson-catalog-cleanup
Make sure all gradle files are pulling dependencies from the Version Catalog
2 parents fb418ae + fb6ede1 commit 0c1ffdb

File tree

4 files changed

+45
-47
lines changed

4 files changed

+45
-47
lines changed

android/app/build.gradle.kts

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -115,31 +115,21 @@ project.extensions.getByName("flutter").apply {
115115
this::class.java.getMethod("source", String::class.java).invoke(this, "../..")
116116
}
117117

118-
val coroutinesVersion = "1.8.1"
119-
val lifecycleVersion = "2.8.2"
120-
val timberVersion = "5.0.1"
121-
val androidxCoreVersion = "1.13.1"
122-
val workManagerVersion = "2.9.0"
123-
val okioVersion = "3.9.0"
124-
125-
val junitVersion = "4.13.2"
126-
val androidxTestVersion = "1.5.0"
127-
128118
dependencies {
129119
implementation(libs.androidx.appcompat)
130120
api(libs.androidx.activity.compose)
131-
coreLibraryDesugaring("com.android.tools:desugar_jdk_libs:2.0.4")
121+
coreLibraryDesugaring(libs.desugar)
132122
implementation(libs.kotlinx.coroutines.android)
133123
implementation(libs.kotlinx.serialization.json)
134124
implementation(libs.libpebblecommon)
135125
implementation(libs.kotlin.reflect)
136-
implementation("androidx.lifecycle:lifecycle-runtime-ktx:$lifecycleVersion")
137-
implementation("androidx.lifecycle:lifecycle-livedata-ktx:$lifecycleVersion")
138-
implementation("androidx.lifecycle:lifecycle-service:$lifecycleVersion")
139-
implementation("com.jakewharton.timber:timber:$timberVersion")
140-
implementation("androidx.core:core-ktx:$androidxCoreVersion")
126+
implementation(libs.androidx.lifecycle.runtime.ktx)
127+
implementation(libs.androidx.lifecycle.livedata.ktx)
128+
implementation(libs.androidx.lifecycle.service)
129+
implementation(libs.timber)
130+
implementation(libs.androidx.core.ktx)
141131
implementation(libs.androidx.work.runtime.ktx)
142-
implementation("com.squareup.okio:okio:$okioVersion")
132+
implementation(libs.okio)
143133
implementation(libs.androidx.room.runtime)
144134
implementation(libs.kotlinx.datetime)
145135
implementation(libs.dagger)
@@ -151,9 +141,9 @@ dependencies {
151141
implementation(project(":shared"))
152142
kapt(libs.dagger.compiler)
153143

154-
testImplementation("junit:junit:$junitVersion")
155-
androidTestImplementation("androidx.test:runner:$androidxTestVersion")
156-
androidTestImplementation("androidx.test:rules:$androidxTestVersion")
144+
testImplementation(libs.junit)
145+
androidTestImplementation(libs.androidx.test.runner)
146+
androidTestImplementation(libs.androidx.test.rules)
157147
}
158148

159-
android.buildTypes.getByName("release").ndk.debugSymbolLevel = "FULL"
149+
android.buildTypes.getByName("release").ndk.debugSymbolLevel = "FULL"

android/gradle/libs.versions.toml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
activityCompose = "1.9.3"
33
android-minSdk = "29"
44
android-targetSdk = "34"
5+
androidxLifecycle = "2.8.2"
56
androidxVersion = "1.15.0"
7+
ble = "1.0.16"
68
coroutinesVersion = "1.8.1"
79
daggerVersion = "2.51.1"
10+
desugar = "2.0.4"
811
gradle = "8.7.2"
912
koinVersion = "4.0.0"
1013
kotlin = "2.1.0-RC"
@@ -13,7 +16,11 @@ kotlinxSerializationJson = "1.7.1"
1316
ksp = "2.1.0-RC-1.0.27"
1417
libpebblecommonVersion = "0.1.27"
1518
errorproneVersion = "2.26.1"
19+
logbackAndroid = "3.0.0"
20+
mockk = "1.13.11"
21+
okio = "3.9.0"
1622
rruleVersion = "1.0.3"
23+
slf4jApi = "2.0.9"
1724
spotbugsVersion = "4.8.6"
1825
atomicfu = "0.25.0"
1926
securityCrypto = "1.1.0-alpha06"
@@ -55,17 +62,27 @@ jetbrains-kotlinx-atomicfu = { id = "org.jetbrains.kotlinx.atomicfu", version.re
5562
[libraries]
5663
androidx-activity-compose = { module = "androidx.activity:activity-compose", version.ref = "activityCompose" }
5764
androidx-core-ktx = { module = "androidx.core:core-ktx", version.ref = "androidxVersion" }
65+
androidx-lifecycle-livedata-ktx = { module = "androidx.lifecycle:lifecycle-livedata-ktx", version.ref = "androidxLifecycle" }
66+
androidx-lifecycle-runtime-ktx = { module = "androidx.lifecycle:lifecycle-runtime-ktx", version.ref = "androidxLifecycle" }
67+
androidx-lifecycle-service = { module = "androidx.lifecycle:lifecycle-service", version.ref = "androidxLifecycle" }
5868
androidx-test-rules = { module = "androidx.test:rules", version.ref = "androidxTest" }
5969
androidx-test-runner = { module = "androidx.test:runner", version.ref = "androidxTest" }
6070
androidx-test-monitor = { module = "androidx.test:monitor", version.ref = "androidxTest" }
6171
androidx-security-crypto-ktx = { module = "androidx.security:security-crypto-ktx", version.ref = "securityCrypto" }
6272
androidx-work-runtime-ktx = { module = "androidx.work:work-runtime-ktx", version.ref = "workManagerVersion" }
73+
ble-core = { module = "no.nordicsemi.android.kotlin.ble:core", version.ref = "ble" }
74+
ble-server = { module = "no.nordicsemi.android.kotlin.ble:server", version.ref = "ble" }
6375
dagger = { module = "com.google.dagger:dagger", version.ref = "daggerVersion" }
6476
dagger-compiler = { module = "com.google.dagger:dagger-compiler", version.ref = "daggerVersion" }
77+
desugar = { module = "com.android.tools:desugar_jdk_libs", version.ref = "desugar" }
6578
gradle = { module = "com.android.tools.build:gradle", version.ref = "gradle" }
6679
kgp = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
6780
errorprone-annotations = { module = "com.google.errorprone:error_prone_annotations", version.ref = "errorproneVersion" }
81+
logback-android = { module = "com.github.tony19:logback-android", version.ref = "logbackAndroid" }
82+
mockk = { module = "io.mockk:mockk", version.ref = "mockk" }
83+
okio = { module = "com.squareup.okio:okio", version.ref = "okio" }
6884
rrule = { module = "com.github.PhilJay:RRule", version.ref = "rruleVersion" }
85+
slf4j-api = { module = "org.slf4j:slf4j-api", version.ref = "slf4jApi" }
6986
spotbugs-annotations = { module = "com.github.spotbugs:spotbugs-annotations", version.ref = "spotbugsVersion" }
7087

7188
androidx-sqlite = { module = "androidx.sqlite:sqlite", version.ref = "room-sqlite" }
@@ -82,6 +99,7 @@ kotlin-reflect = { module = "org.jetbrains.kotlin:kotlin-reflect", version.ref =
8299
kotlinx-coroutines-core = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core", version.ref = "coroutinesVersion" }
83100
kotlinx-coroutines-debug = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-debug", version.ref = "coroutinesVersion" }
84101
kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version.ref = "coroutinesVersion" }
102+
kotlinx-coroutines-test = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "coroutinesVersion" }
85103
kotlinx-datetime = { module = "org.jetbrains.kotlinx:kotlinx-datetime", version.ref = "kotlinxDatetime" }
86104
kotlinx-serialization-json = { module = "org.jetbrains.kotlinx:kotlinx-serialization-json", version.ref = "kotlinxSerializationJson" }
87105
kotlinx-serialization-core = { module = "org.jetbrains.kotlinx:kotlinx-serialization-core", version.ref = "kotlinxSerializationJson" }

android/pebble_bt_transport/build.gradle.kts

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -33,37 +33,31 @@ android {
3333
}
3434
}
3535

36-
val timberVersion = "4.7.1"
37-
val coroutinesVersion = "1.8.0"
38-
val okioVersion = "3.7.0"
39-
val mockkVersion = "1.13.11"
40-
val nordicBleVersion = "1.0.16"
41-
4236
dependencies {
43-
implementation("androidx.core:core-ktx:1.13.1")
44-
implementation("androidx.appcompat:appcompat:1.6.1")
37+
implementation(libs.androidx.core.ktx)
38+
implementation(libs.androidx.appcompat)
4539
implementation(libs.libpebblecommon)
46-
implementation("com.jakewharton.timber:timber:$timberVersion")
40+
implementation(libs.timber)
4741
// for nordic ble
48-
implementation("org.slf4j:slf4j-api:2.0.9")
49-
implementation("com.github.tony19:logback-android:3.0.0")
42+
implementation(libs.slf4j.api)
43+
implementation(libs.logback.android)
5044

51-
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:$coroutinesVersion")
52-
implementation("com.squareup.okio:okio:$okioVersion")
45+
implementation(libs.kotlinx.coroutines.android)
46+
implementation(libs.okio)
5347
implementation(libs.kotlinx.serialization.json)
5448

5549

5650

57-
implementation("no.nordicsemi.android.kotlin.ble:core:$nordicBleVersion")
58-
implementation("no.nordicsemi.android.kotlin.ble:server:$nordicBleVersion")
51+
implementation(libs.ble.core)
52+
implementation(libs.ble.server)
5953
implementation(project(":shared"))
6054

61-
testImplementation("junit:junit:4.13.2")
62-
testImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:$coroutinesVersion")
63-
testImplementation("io.mockk:mockk:$mockkVersion")
55+
testImplementation(libs.junit)
56+
testImplementation(libs.kotlinx.coroutines.test)
57+
testImplementation(libs.mockk)
6458

65-
androidTestImplementation("androidx.test.ext:junit:1.1.5")
66-
androidTestImplementation("androidx.test.espresso:espresso-core:3.5.1")
67-
androidTestImplementation("androidx.test:rules:1.5.0")
68-
androidTestImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:$coroutinesVersion")
59+
androidTestImplementation(libs.androidx.junit)
60+
androidTestImplementation(libs.androidx.espresso.core)
61+
androidTestImplementation(libs.androidx.test.rules)
62+
androidTestImplementation(libs.kotlinx.coroutines.test)
6963
}

android/shared/build.gradle.kts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ plugins {
1212
alias(libs.plugins.jetbrains.kotlinx.atomicfu)
1313
}
1414

15-
val timberVersion = "5.0.1"
16-
val androidxVersion = "1.13.1"
17-
val rruleVersion = "1.0.3"
18-
1915
kotlin {
2016
androidTarget {
2117
compilations.all {

0 commit comments

Comments
 (0)