Skip to content

Commit 272ee6a

Browse files
Do not announce generated watchfaces in the same way
1 parent 7df7f4a commit 272ee6a

File tree

3 files changed

+24
-13
lines changed

3 files changed

+24
-13
lines changed

appstore/developer_portal_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ def submit_new_app():
185185
algolia_index.partial_update_objects([algolia_app(app_obj)], { 'createIfNotExists': True })
186186

187187
try:
188-
announce_new_app(app_obj)
188+
announce_new_app(app_obj, pbw.is_generated())
189189
except Exception:
190190
# We don't want to fail just because Discord is being weird
191191
print("Discord is being weird")
@@ -314,7 +314,7 @@ def submit_new_release(app_id):
314314
db.session.commit()
315315

316316
try:
317-
announce_release(app, release_new)
317+
announce_release(app, release_new, pbw.is_generated())
318318
except Exception:
319319
# We don't want to fail just because Discord webhook is being weird
320320
print("Discord is being weird")

appstore/discord.py

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
def random_party_emoji():
1212
return random.choice(party_time_emoji)
1313

14-
def announce_release(app, release):
14+
def announce_release(app, release, is_generated):
1515
release_notes = release.release_notes
1616
if not release_notes:
1717
release_notes = "N/A"
@@ -35,9 +35,9 @@ def announce_release(app, release):
3535
}]
3636
}
3737

38-
send_discord_webhook(request_data)
38+
send_discord_webhook(request_data, is_generated)
3939

40-
def announce_new_app(app):
40+
def announce_new_app(app, is_generated):
4141
request_fields = [{
4242
"name": "Name",
4343
"value": app.title
@@ -70,11 +70,13 @@ def announce_new_app(app):
7070
"value": app.website
7171
})
7272

73+
txt_type = app.type if not is_generated else "Generated Watchface"
74+
7375
request_data = {
7476
"embeds": [{
75-
"title": f"New {str(app.type).capitalize()} Alert {random_party_emoji()}",
77+
"title": f"New {str(txt_type).capitalize()} Alert {random_party_emoji()}",
7678
"url": f"{config['APPSTORE_ROOT']}/application/{app.id}",
77-
"description": f"There's a new {app.type} on the appstore!",
79+
"description": f"There's a new {txt_type} on the appstore!",
7880
"thumbnail": {
7981
"url": generate_image_url(app.icon_large, 80, 80, True, True),
8082
"height": 80,
@@ -83,8 +85,8 @@ def announce_new_app(app):
8385
"fields": request_fields
8486
}]
8587
}
86-
87-
send_discord_webhook(request_data)
88+
89+
send_discord_webhook(request_data, is_generated)
8890

8991
def audit_log(operation):
9092
request_fields = [{
@@ -112,10 +114,15 @@ def audit_log(operation):
112114

113115
send_admin_discord_webhook(request_data)
114116

115-
def send_discord_webhook(request_data):
116-
if config['DISCORD_HOOK_URL'] is not None:
117-
headers = {'Content-Type': 'application/json'}
118-
requests.post(config['DISCORD_HOOK_URL'], data=json.dumps(request_data), headers=headers)
117+
def send_discord_webhook(request_data, is_generated = False):
118+
if not is_generated:
119+
if config['DISCORD_HOOK_URL'] is not None:
120+
headers = {'Content-Type': 'application/json'}
121+
requests.post(config['DISCORD_HOOK_URL'], data=json.dumps(request_data), headers=headers)
122+
else:
123+
if config['DISCORD_GENERATED_HOOK_URL'] is not None:
124+
headers = {'Content-Type': 'application/json'}
125+
requests.post(config['DISCORD_GENERATED_HOOK_URL'], data=json.dumps(request_data), headers=headers)
119126

120127
def send_admin_discord_webhook(request_data):
121128
if config['DISCORD_ADMIN_HOOK_URL'] is not None:

appstore/pbw.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
from .utils import id_generator
1414

1515
PLATFORMS = ['aplite', 'basalt', 'chalk', 'diorite', 'emery']
16+
GENERATED_ID_PREFIX = "13371337"
1617

1718
class PBW(object):
1819
MANIFEST_FILENAME = 'manifest.json'
@@ -121,6 +122,9 @@ def get_app_metadata(self):
121122
}
122123
return self.header
123124

125+
def is_generated(self):
126+
return str(self.get_app_metadata()["uuid"]).startswith(GENERATED_ID_PREFIX)
127+
124128
def close(self):
125129
self.zip.close()
126130

0 commit comments

Comments
 (0)