Bug in io.pedestal.app.diff/model-diff-inform

[danielcompton]

I'm not sure if I'm not understanding it correctly but it seems like there is a bug in https://github.com/pedestal/pedestal-app/blob/master/app/src/io/pedestal/app/diff.clj#L42

I run

(model-diff-inform {:a 1} {:a 1 :b 2})
;;[[[:b] :added {:a 1} {:a 1, :b 2}]]
(model-diff-inform {:a 1 :b 2} {:a 1})
;;[]

I would expect that (model-diff-inform {:a 1 :b 2} {:a 1}) would return something like [[[:b] :removed {:a 1, :b 2} {:a 1}]]

Is this expected behaviour?

[qtrfeast]

That does seem odd. If you investigate the generative tests and things do indeed seem off then I would accept a bug fix.

[brentonashworth]

You expect correctly. If that is what is happening then it is a bug. I am
surprised that we don't currently have a test for this very basic case.

On Saturday, February 15, 2014, Daniel Compton notifications@github.com
wrote:

I'm not sure if I'm not understanding it correctly but it seems like there
is a bug in
https://github.com/pedestal/pedestal-app/blob/master/app/src/io/pedestal/app/diff.clj#L42

I run

(model-diff-inform {:a 1} {:a 1 :b 2})
;;[[[:b] :added {:a 1} {:a 1, :b 2}]](model-diff-inform {:a 1 :b 2} {:a 1})
;;[]

I would expect that (model-diff-inform {:a 1 :b 2} {:a 1}) would return
something like ;;[[[:b] :removed {:a 1, :b 2} {:a 1}]]

Is this expected behaviour?

Reply to this email directly or view it on GitHubhttps://github.com//issues/18
.