Init Node Tests

Author: pedrozadotdev

nodes/HttpForwardAuth/HttpForwardAuthTrigger.node.ts

@@ -114,7 +114,7 @@ export class HttpForwardAuthTrigger implements INodeType {
 				res.status(403).send('Error 403 - Forbidden').end();
 			} else {
 				deleteSessionTokenCookie(addResHeader);
-				res.redirect(logoutRedirectURL);
+				res.status(302).redirect(logoutRedirectURL);
 			}
 		}
 		return {

nodes/HttpForwardAuth/transport.ts

@@ -5,8 +5,8 @@ import { setupRedisClient } from './utils';
 
 let instance: ConnectionPoolManager;
 
-// 2 hours
-const ttl = 2 * 60 * 60 * 1000;
+// ~2 hours
+const ttl = 2 * 60 * 60 * 1000 - 1;
 
 // 30 minutes
 const cleanUpInterval = 30 * 60 * 1000;

nodes/HttpForwardAuth/types.ts

@@ -1,3 +1,4 @@
+/* c8 ignore start */
 import type { createClient } from 'redis';
 
 export type RedisCredential = {
@@ -19,3 +20,4 @@ export type Redis = {
 	client: ReturnType<typeof createClient>;
 	RATE_LIMIT_SHA: string;
 };
+/* c8 ignore stop */

nodes/HttpForwardAuth/utils.ts

@@ -132,7 +132,7 @@ export function setSessionTokenCookie(
 ): void {
 	addResHeader(
 		'Set-Cookie',
-		`${SESSION_KEY}=${token}; HttpOnly; SameSite=Lax; Expires=${expiresAt.toUTCString()}; Path=/${enableHTTP ? '' : '; Secure;'}`,
+		`${SESSION_KEY}=${token}; HttpOnly; SameSite=Lax; Expires=${expiresAt.toUTCString()}; Path=/${enableHTTP ? '' : '; Secure'}`,
 	);
 }
 
@@ -142,7 +142,7 @@ export function deleteSessionTokenCookie(
 ): void {
 	addResHeader(
 		'Set-Cookie',
-		`${SESSION_KEY}=; HttpOnly; SameSite=Lax; Max-Age=0; Path=/${enableHTTP ? '' : '; Secure;'}`,
+		`${SESSION_KEY}=; HttpOnly; SameSite=Lax; Max-Age=0; Path=/${enableHTTP ? '' : '; Secure'}`,
 	);
 }
 

package.json

@@ -30,7 +30,7 @@
     "lint": "eslint nodes credentials package.json",
     "lintfix": "eslint nodes credentials package.json --fix",
     "prepublishOnly": "pnpm build && pnpm lint -c .eslintrc.prepublish.js nodes credentials package.json",
-    "test": "jest",
+    "test": "jest --silent=false",
     "test-watch": "jest --watch"
   },
   "files": [
@@ -45,6 +45,7 @@
   },
   "devDependencies": {
     "@scure/base": "^1.2.4",
+    "@types/express": "^5.0.0",
     "@types/jest": "^29.5.14",
     "@types/node": "^22.13.1",
     "@typescript-eslint/parser": "^7.15.0",

pnpm-lock.yaml

@@ -0,0 +1,29 @@
+import { createClient } from 'redis';
+import { getPoolManagerInstance } from '../nodes/HttpForwardAuth/transport';
+import type { RedisCredential } from '../nodes/HttpForwardAuth/types';
+
+export const setupRedis = (mockOverrides?: Record<string, unknown>) => {
+	(createClient as jest.Mock).mockImplementation(() => ({
+		connect: async () => 'CONNECTED',
+		disconnect: async () => 'DISCONNECTED',
+		scriptLoad: async () => 'RATE_LIMIT_SHA',
+		ping: async () => 'PONG',
+		get: async () => 'GET',
+		set: async () => 'SET',
+		del: async () => 'DEL',
+		evalSha: async () => 'EVALSHA',
+		...mockOverrides,
+	}));
+};
+
+export const resetRedis = async () => {
+	const poolManager = getPoolManagerInstance();
+	await poolManager.purgeConnections();
+};
+
+export const resetJest = () => {
+	jest.resetAllMocks();
+	jest.useRealTimers();
+}
+
+export const credentialsMock: RedisCredential = { host: 'redis', port: 6379, database: 0 };

test/helpers.ts

@@ -10,7 +10,7 @@ const cookies = [
 	'asd-asd-asd',
 ];
 
-describe('CookieParse', () => {
+describe('CookieParse Suite', () => {
 	it('Should parse cookies correctly', () => {
 		expect(cookieParse(cookies[0])['AAA-Aaaa-Aaaaaa']).toBe('00-Aaa-0000');
 		expect(cookieParse(cookies[0]).DddDD).toBe('DD:DD:Ddd_Ddddddddd:33.33:-333.33:d3');

test/libs/cookieParser.test.ts

@@ -7,7 +7,7 @@ import {
 import { SHA256 } from '../../nodes/HttpForwardAuth/oslojs/sha2/sha256';
 import { bigEndian, rotr32 } from '../../nodes/HttpForwardAuth/oslojs/binary';
 
-describe('Oslojs', () => {
+describe('Oslojs Suite', () => {
 	it('Should encode to HexLowerCase', () => {
 		const cases = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
 		for (const length of cases) {

test/libs/oslojs.test.ts

@@ -0,0 +1,20 @@
+import { getRedisClient } from "../../nodes/HttpForwardAuth/transport";
+import { resetJest, resetRedis, setupRedis, credentialsMock } from "../helpers";
+
+jest.mock('redis', () => ({
+	__esModule: true,
+	createClient: jest.fn(),
+}));
+
+jest.useFakeTimers();
+
+describe('Response Suite', () => {
+	afterAll(resetJest);
+	afterEach(resetRedis);
+
+	it('Test', async () => {
+		setupRedis();
+		await getRedisClient(credentialsMock);
+		expect(true).toBe(true)
+	})
+});