Finish Test Suites

Author: pedrozadotdev

nodes/HttpForwardAuth/HttpForwardAuth.node.ts

@@ -107,6 +107,15 @@ export class HttpForwardAuth implements INodeType {
 			};
 			this.sendResponse(response);
 		} catch (error) {
+			this.sendResponse({
+				body: '500 Internal Server Error',
+				__bodyResolved: true,
+				headers: {
+					[FORWARDED_USER_HEADER]: '',
+				},
+				statusCode: 500,
+			});
+
 			if (this.continueOnFail()) {
 				returnData = [{ json: { error: (error as { message: string }).message } }];
 				return [returnData];

test/helpers.ts

@@ -42,6 +42,7 @@ type ResponseOpts = {
 		data?: Record<string, unknown>,
 		params?: TriggerOpts['params']
 	}
+	continueOnFail: boolean;
 };
 
 export const setupRedis = (mockOverrides?: Record<string, unknown>) => {
@@ -183,7 +184,8 @@ const defaultResponseOpts: ResponseOpts = {
 			loginTemplate: '#LOGIN_URL#|#ERROR_MESSAGE#'
 		},
 		data: { remoteIp: 'REMOTE_IP' }
-	}
+	},
+	continueOnFail: false
 };
 
 export const setupResponse = (opts?: Partial<ResponseOpts>) => {
@@ -194,7 +196,7 @@ export const setupResponse = (opts?: Partial<ResponseOpts>) => {
 			...defaultResponseOpts.params,
 			...(opts?.params ?? {}),
 		},
-		parentNodes: [...(opts?.parentNodes ?? [])],
+		parentNodes: [...(opts?.parentNodes ?? defaultResponseOpts.parentNodes)],
 		triggerData: {
 			params: {
 				...defaultResponseOpts.triggerData.params,
@@ -204,7 +206,8 @@ export const setupResponse = (opts?: Partial<ResponseOpts>) => {
 				...defaultResponseOpts.triggerData.data,
 				...(opts?.triggerData?.data ?? {})
 			}
-		}
+		},
+		continueOnFail: opts?.continueOnFail ?? defaultResponseOpts.continueOnFail
 	};
 
 	const mocks = {
@@ -227,7 +230,7 @@ export const setupResponse = (opts?: Partial<ResponseOpts>) => {
 			}
 		}),
 		sendResponse: sendResponseMock,
-		continueOnFail: () => false,
+		continueOnFail: () => store.continueOnFail,
 	});
 
 	return { context, mocks };

test/nodes/response.test.ts

@@ -1,5 +1,6 @@
 import { resetJest, resetRedis, setupResponse } from '../helpers';
 import { HttpForwardAuth } from '../../nodes/HttpForwardAuth/HttpForwardAuth.node';
+import { FORWARDED_USER_HEADER } from '../../nodes/HttpForwardAuth/constants';
 
 jest.mock('redis', () => ({
 	__esModule: true,
@@ -13,10 +14,77 @@ describe('Response Suite', () => {
 	afterEach(resetRedis);
 
 	it('Should fail if no HttpForwardAuthTrigger is found on workflow', async () => {
-		const { context } = setupResponse();
+		const { context, mocks } = setupResponse({ parentNodes: [] });
 		const node = new HttpForwardAuth();
 
-		const bindExecute = node.execute.bind(context);
-		expect(() => bindExecute()).rejects.toThrow('No HttpForwardAuthTrigger node found in the workflow')
+		try {
+			await node.execute.bind(context)();
+		} catch (error) {
+			expect(error.message).toBe('No HttpForwardAuthTrigger node found in the workflow');
+			expect(mocks.sendResponseMock).toHaveBeenCalledWith({
+				body: '500 Internal Server Error',
+				__bodyResolved: true,
+				headers: {
+					[FORWARDED_USER_HEADER]: '',
+				},
+				statusCode: 500,
+			});
+		}
+		expect.assertions(2);
 	});
-})
+
+	it('Should not fail if continueOnFail is true', async () => {
+		const { context, mocks } = setupResponse({ parentNodes: [], continueOnFail: true });
+		const node = new HttpForwardAuth();
+
+		expect(await node.execute.bind(context)()).toStrictEqual([
+			[{ json: { error: 'No HttpForwardAuthTrigger node found in the workflow' } }],
+		]);
+		expect(mocks.sendResponseMock).toHaveBeenCalledWith({
+			body: '500 Internal Server Error',
+			__bodyResolved: true,
+			headers: {
+				[FORWARDED_USER_HEADER]: '',
+			},
+			statusCode: 500,
+		});
+	});
+
+	it('Should authenticate user successfully', async () => {
+		const { context, mocks } = setupResponse({ params: { userID: 'user' } });
+		const node = new HttpForwardAuth();
+
+		expect(await node.execute.bind(context)()).toStrictEqual([
+			[{ json: { remoteIp: 'REMOTE_IP', status: 'success', user: 'user' } }],
+		]);
+		expect(mocks.sendResponseMock).toHaveBeenCalledWith({
+			__bodyResolved: true,
+			body: undefined,
+			headers: {
+				'Set-Cookie': expect.stringMatching(
+					/n8n_hfa_session=[A-Za-z0-9]{32}; HttpOnly; SameSite=Lax; Expires=Mon, \d{1,2} \w{3} \d{4} \d{2}:\d{2}:\d{2} GMT; Path=\/; Secure/g,
+				),
+				location: 'http://localhost:8080/protected',
+			},
+			statusCode: 302,
+		});
+	});
+
+	it('Should fail to authenticate the user', async () => {
+		const { context, mocks } = setupResponse();
+		const node = new HttpForwardAuth();
+
+		expect(await node.execute.bind(context)()).toStrictEqual([
+			[{ json: { remoteIp: 'REMOTE_IP', status: 'fail' } }],
+		]);
+		expect(mocks.sendResponseMock).toHaveBeenCalledWith({
+			__bodyResolved: true,
+			body: 'http://localhost:8080/login|Validation Error',
+			headers: {
+				'X-Forwarded-User': '',
+				'content-type': 'text/html',
+			},
+			statusCode: 401,
+		});
+	});
+});