Skip to content

Commit 9b45716

Browse files
committed
Remove SimpleCov/Codecov - not useful for Puppet modules
- Remove coverage job from CI workflow - Remove SimpleCov configuration from spec_helper.rb - Remove simplecov gems from Gemfile RSpec-Puppet resource coverage is more meaningful for Puppet modules and is already included via RSpec::Puppet::Coverage.reportstrings
1 parent 0841fac commit 9b45716

File tree

3 files changed

+0
-50
lines changed

3 files changed

+0
-50
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -96,36 +96,6 @@ jobs:
9696
env:
9797
PUPPET_GEM_VERSION: "~> ${{ matrix.puppet }}"
9898

99-
coverage:
100-
name: Code Coverage
101-
runs-on: ubuntu-latest
102-
needs: unit
103-
steps:
104-
- name: Checkout
105-
uses: actions/checkout@v4
106-
107-
- name: Setup Ruby
108-
uses: ruby/setup-ruby@v1
109-
with:
110-
ruby-version: '3.2'
111-
bundler-cache: true
112-
113-
- name: Install dependencies
114-
run: bundle install
115-
116-
- name: Run tests with coverage
117-
run: bundle exec rake spec
118-
env:
119-
COVERAGE: 'yes'
120-
121-
- name: Upload coverage to Codecov
122-
uses: codecov/codecov-action@v4
123-
with:
124-
files: coverage/.resultset.json
125-
fail_ci_if_error: false
126-
env:
127-
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
128-
12999
release:
130100
name: Release to Puppet Forge
131101
runs-on: ubuntu-latest

Gemfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ group :development, :test do
1414
gem 'metadata-json-lint'
1515
gem 'puppet-lint'
1616
gem 'puppet-syntax'
17-
gem 'simplecov', require: false
18-
gem 'simplecov-console', require: false
1917
end
2018

2119
group :acceptance do

spec/spec_helper.rb

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,6 @@
55

66
include RspecPuppetFacts
77

8-
# Configure SimpleCov for code coverage
9-
if ENV['COVERAGE'] == 'yes'
10-
require 'simplecov'
11-
require 'simplecov-console'
12-
13-
SimpleCov.start do
14-
add_filter '/spec/'
15-
add_filter '/vendor/'
16-
track_files 'manifests/**/*.pp'
17-
enable_coverage :branch
18-
end
19-
20-
SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
21-
SimpleCov::Formatter::HTMLFormatter,
22-
SimpleCov::Formatter::Console
23-
])
24-
end
25-
268
# Default facts for all tests
279
default_facts = {
2810
puppetversion: Puppet.version,

0 commit comments

Comments
 (0)