Improvements for setup participants bottom sheet (#306)

willyfromtheblock · yurtpage · sandakersmann · web-flow · commit facfe2bda80a · 2025-06-25T10:17:45.000Z
* Translated using Weblate (Russian) Currently translated at 100.0% (3 of 3 strings) Translation: Peercoin Flutter/metadata Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/metadata/ru/ * Translated using Weblate (Russian) Currently translated at 100.0% (3 of 3 strings) Translation: Peercoin Flutter/metadata Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/metadata/ru/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 100.0% (3 of 3 strings) Translation: Peercoin Flutter/metadata Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/metadata/nb_NO/ * Translated using Weblate (Croatian) Currently translated at 68.2% (397 of 582 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/hr/ * Translated using Weblate (Croatian) Currently translated at 77.4% (451 of 582 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/hr/ * Translated using Weblate (Spanish) Currently translated at 92.7% (540 of 582 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/es/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 86.7% (603 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/nb_NO/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/nb_NO/ * Translated using Weblate (Swahili) Currently translated at 49.6% (345 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/sw/ * Translated using Weblate (Swedish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/sv/ * Translated using Weblate (Danish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/da/ * Translated using Weblate (Spanish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/es/ * Translated using Weblate (Spanish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/es/ * Translated using Weblate (Spanish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/es/ * Translated using Weblate (Spanish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/es/ * Translated using Weblate (Spanish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/es/ * Translated using Weblate (Icelandic) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/is/ * Translated using Weblate (Swahili) Currently translated at 49.6% (345 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/sw/ * Translated using Weblate (Swedish) Currently translated at 100.0% (3 of 3 strings) Translation: Peercoin Flutter/metadata Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/metadata/sv/ * Translated using Weblate (Danish) Currently translated at 100.0% (3 of 3 strings) Translation: Peercoin Flutter/metadata Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/metadata/da/ * Translated using Weblate (Icelandic) Currently translated at 100.0% (3 of 3 strings) Translation: Peercoin Flutter/metadata Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/metadata/is/ * Translated using Weblate (Spanish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/es/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/nb_NO/ * Translated using Weblate (Swedish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/sv/ * Translated using Weblate (Danish) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/da/ * Translated using Weblate (Icelandic) Currently translated at 100.0% (695 of 695 strings) Translation: Peercoin Flutter/Translations Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/is/ * Add QR code scanning and group configuration import features for ROAST participants * Enhance participant sharing interface with detailed sections for name, identifier, and public key * Bump version to 1.4.4 and update CHANGELOG with UI improvements for ROAST participant onboarding * Refactor border color opacity handling in participant share UI * Enable code shrinking and obfuscation for release builds; update Gradle properties for improved performance --------- Co-authored-by: Yurt Page <yurtpage@gmail.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: peerchemist <dx.1178@gmail.com> Co-authored-by: Jose l. Azagra <azagramac@gmail.com> Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: Hampherny Rico <hamphernyr@gmail.com>
diff --git a/.vscode/mcp.json b/.vscode/mcp.json
@@ -0,0 +1,18 @@
+{
+  "inputs": [
+    // The "inputs" section defines the inputs required for the MCP server configuration.
+    {
+      "type": "promptString"
+    }
+  ],
+  "servers": {
+    "Context7": {
+      "type": "stdio",
+      "command": "bunx",
+      "args": [
+        "-y",
+        "@upstash/context7-mcp"
+      ]
+    }
+  }
+}
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### **1.4.4** (2025-06-25)
+
+- UI Improvements for ROAST participant onboarding
+
 ### **1.4.3** (2025-05-30)
 
 - More dark mode fixes
diff --git a/android/app/build.gradle b/android/app/build.gradle
@@ -73,6 +73,11 @@ android {
     buildTypes {
         release {
             signingConfig signingConfigs.release
+            minifyEnabled true
+            shrinkResources true
+            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
+        }
+        debug {
             minifyEnabled false
             shrinkResources false
         }
diff --git a/android/app/proguard-rules.pro b/android/app/proguard-rules.pro
@@ -0,0 +1,51 @@
+# Keep Google Tink annotation classes
+-keep class com.google.errorprone.annotations.** { *; }
+-dontwarn com.google.errorprone.annotations.**
+
+# Keep Checker Framework annotations
+-keep class org.checkerframework.checker.nullness.qual.** { *; }
+-dontwarn org.checkerframework.checker.nullness.qual.**
+
+# Keep other annotation classes that might be missing
+-keep class javax.annotation.** { *; }
+-dontwarn javax.annotation.**
+
+# Keep Google Tink classes
+-keep class com.google.crypto.tink.** { *; }
+-dontwarn com.google.crypto.tink.**
+
+# Keep crypto-related classes that might be accessed via reflection
+-keep class * implements javax.crypto.** { *; }
+-keep class * extends javax.crypto.** { *; }
+
+# Keep Flutter secure storage native classes
+-keep class com.it_nomads.fluttersecurestorage.** { *; }
+
+# Keep coinlib and crypto-related native classes
+-keep class coinlib.** { *; }
+-keep class frosty.** { *; }
+
+# Keep gRPC and protobuf classes
+-keep class io.grpc.** { *; }
+-keep class com.google.protobuf.** { *; }
+
+# General rules for common issues
+-dontwarn java.lang.reflect.**
+-dontwarn java.beans.**
+-dontwarn javax.lang.model.**
+
+# Keep native methods
+-keepclasseswithmembernames class * {
+    native <methods>;
+}
+
+# Keep Parcelable implementations
+-keep class * implements android.os.Parcelable {
+    public static final android.os.Parcelable$Creator *;
+}
+
+# Keep enum values
+-keepclassmembers enum * {
+    public static **[] values();
+    public static ** valueOf(java.lang.String);
+}
diff --git a/android/gradle.properties b/android/gradle.properties
@@ -1,4 +1,4 @@
-org.gradle.jvmargs=-Xmx1536M
+org.gradle.jvmargs=-Xmx4g -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8
 android.useAndroidX=true
 android.enableJetifier=true
 android.enableR8=true
diff --git a/assets/translations/da.json b/assets/translations/da.json
@@ -620,7 +620,7 @@
     "roast_wallet_request_dkg_name": "Navn",
     "roast_wallet_request_dkg_description": "Beskrivelse",
     "roast_wallet_request_dkg_threshold": "Tærskel",
-    "roast_wallet_request_dkg_threshold_hint": "Antal påkrævede signaturer",
+    "roast_wallet_request_dkg_threshold_hint": "Antal obligatoriske deltagere, der accepterer",
     "roast_wallet_request_dkg_threshold_empty_error": "Indtast venligst en tærskel",
     "roast_wallet_request_dkg_threshold_not_number_error": "Tærsklen skal være et tal",
     "roast_wallet_request_dkg_threshold_too_large_error": "Tærsklen må højst være $max",
diff --git a/assets/translations/en.json b/assets/translations/en.json
@@ -693,5 +693,19 @@
   "roast_hd_index_invalid_error": "Please enter a valid number",
   "roast_hd_index_range_error": "Index must be greater or equal to 0",
   "confirm": "Confirm",
-  "cancel": "Cancel"
+  "cancel": "Cancel",
+  "roast_setup_scan_qr_participant": "Scan QR Code for Participant",
+  "roast_setup_qr_scan_title": "Scan Participant QR Code",
+  "roast_setup_qr_invalid_format": "Invalid QR code format",
+  "roast_setup_share_participant_qr_title": "Share as QR Code",
+  "roast_setup_share_participant_qr_description": "Others can scan this QR code to add you as a participant",
+  "roast_setup_share_participant_qr_share": "Share QR Data",
+  "roast_setup_participant_data_loaded_from_qr": "Participant data loaded from QR code",
+  "roast_setup_group_member_manual_entry_hint": "Or enter participant details manually:",
+  "roast_setup_share_participant_details_title": "Share Participant Details",
+  "roast_setup_share_participant_name_title": "Name",
+  "roast_setup_share_participant_identifier_title": "Identifier",
+  "roast_setup_share_participant_identifier_description": "Unique identifier generated from your name",
+  "roast_setup_share_participant_pubkey_title": "Public Key",
+  "roast_setup_share_participant_pubkey_description": "Your cryptographic public key (hex format)"
 }
diff --git a/assets/translations/es.json b/assets/translations/es.json
@@ -551,7 +551,7 @@
     "roast_setup_group_fingerprint_description": "Verifique la huella digital con todos los miembros del grupo para asegurarse de que todas las claves públicas son correctas.",
     "roast_landing_configured_login_failed_snack_fingerprint_mismatch": "Error en el inicio de sesión. Huella digital no coincidente.",
     "roast_wallet_signature_input_selector_available_utxos": "Entradas Disponibles",
-    "roast_wallet_request_dkg_threshold_hint": "Número de firmas requeridas",
+    "roast_wallet_request_dkg_threshold_hint": "Número de participantes aceptantes requeridos",
     "roast_wallet_request_dkg_threshold_too_small_error": "El umbral debe ser de al menos 2",
     "roast_wallet_request_dkg_groupsize_equals_two_hint": "Sugerencia: El tamaño del grupo es demasiado pequeño para configurar el umbral.",
     "roast_wallet_request_signature_derivation_path_invalid_error": "El índice de derivación debe ser un número",
diff --git a/assets/translations/is.json b/assets/translations/is.json
@@ -586,7 +586,7 @@
     "roast_setup_landing_experimental_warning": "Þetta er tilraunaeiginleiki sem hefur ekki verið prófaður að fullu ennþá. Vinsamlegast notið þetta á eigin ábyrgð. \n Allar lokadagsetningar tengdar beiðnum eru sjálfgefnar eins dags og verða stillanlegar í framtíðinni. \n \nEf þú lendir í einhverjum vandræðum, vinsamlegast tilkynntu þau á GitHub. \n Notkun tilraunakennda ROAST-eiginleikans krefst tengingar við gRPC-þjón með Marisma-samskiptareglum, sem er hýst af peercoin_flutter teyminu. Ekki er hægt að stilla harðkóðuðu vefslóðirnar (marisma.ppc.lol) eins og er. Frumkóði Marisma verður gefinn út fljótlega. ",
     "roast_landing_configured_login_failed_snack_fingerprint_mismatch": "Innskráning mistókst. Fingrafarið passar ekki.",
     "roast_wallet_signature_input_selector_title": "Veldu hvaða inntak á að undirrita",
-    "roast_wallet_request_dkg_threshold_hint": "Fjöldi undirskrifta sem krafist er",
+    "roast_wallet_request_dkg_threshold_hint": "Fjöldi þátttakenda sem þarf að samþykkja",
     "roast_wallet_request_dkg_threshold_too_large_error": "Þröskuldurinn má ekki vera meira en $max",
     "roast_wallet_request_dkg_name_used_error": "Nafnið er þegar í notkun",
     "roast_wallet_request_signature_derivation_path_invalid_error": "Afleiðuvísitalan verður að vera tala",
diff --git a/assets/translations/nb_NO.json b/assets/translations/nb_NO.json
@@ -615,7 +615,7 @@
     "roast_wallet_request_dkg_name": "Navn",
     "roast_wallet_request_dkg_description": "Beskrivelse",
     "roast_wallet_request_dkg_threshold": "Terskel",
-    "roast_wallet_request_dkg_threshold_hint": "Antall nødvendige signaturer",
+    "roast_wallet_request_dkg_threshold_hint": "Antall påkrevde deltakere som aksepterer",
     "roast_wallet_request_dkg_threshold_empty_error": "Vennligst angi en terskel",
     "roast_wallet_request_dkg_threshold_not_number_error": "Terskelen må være et tall",
     "roast_wallet_request_dkg_threshold_too_small_error": "Terskelen må være minst 2",
diff --git a/assets/translations/sv.json b/assets/translations/sv.json
@@ -636,7 +636,7 @@
     "roast_wallet_request_signature_success_snack": "Signaturförfrågan har skickats",
     "roast_wallet_request_signature_error_snack": "Kunde inte skicka signaturförfrågan",
     "roast_wallet_request_signature_no_key_error": "Ingen gruppnyckel vald",
-    "roast_wallet_request_dkg_threshold_hint": "Antal signaturer som krävs",
+    "roast_wallet_request_dkg_threshold_hint": "Antal obligatoriska deltagare som accepterar",
     "roast_wallet_request_signature_derived_address_empty_error": "Välj en härledd adress",
     "roast_wallet_request_signature_derived_address": "Härledd Adress",
     "roast_wallet_request_signature_select_address": "Välj Adress",
diff --git a/lib/screens/wallet/roast/roast_wallet_add_participant.dart b/lib/screens/wallet/roast/roast_wallet_add_participant.dart
@@ -4,7 +4,11 @@ import 'package:flutter/services.dart';
 import 'package:noosphere_roast_client/noosphere_roast_client.dart';
 import 'package:peercoin/models/hive/roast_wallet.dart';
 import 'package:peercoin/tools/app_localizations.dart';
+import 'package:peercoin/tools/app_routes.dart';
+import 'package:peercoin/tools/logger_wrapper.dart';
 import 'package:peercoin/widgets/service_container.dart';
+import 'package:peercoin/widgets/buttons.dart';
+import 'dart:convert';
 
 class ParticpantNavigatorPopDTO {
   final Identifier identifier;
@@ -71,6 +75,80 @@ class _ROASTWalletAddParticipantScreenState
     }
   }
 
+  void _scanQRCodeForParticipant() async {
+    LoggerWrapper.logInfo(
+      'ROASTWalletAddParticipantScreen',
+      '_scanQRCodeForParticipant',
+      'Scanning QR code for participant',
+    );
+
+    final result = await Navigator.of(context).pushNamed(
+      Routes.qrScan,
+      arguments:
+          AppLocalizations.instance.translate('roast_setup_qr_scan_title'),
+    );
+
+    if (result != null && result is String) {
+      try {
+        // Try to parse as JSON (individual participant)
+        final participantData = jsonDecode(result);
+
+        if (participantData['name'] != null &&
+            participantData['publicKey'] != null) {
+          final name = participantData['name'] as String;
+          final publicKeyHex = participantData['publicKey'] as String;
+
+          // Validate public key format
+          ECCompressedPublicKey.fromHex(publicKeyHex);
+
+          // Auto-fill the form with scanned data
+          setState(() {
+            _nameController.text = name;
+            _ecPubKeyController.text = publicKeyHex;
+            _type =
+                ParticipantType.name; // Default to name type for scanned data
+          });
+
+          LoggerWrapper.logInfo(
+            'ROASTWalletAddParticipantScreen',
+            '_scanQRCodeForParticipant',
+            'QR code data loaded: $name',
+          );
+
+          if (mounted) {
+            ScaffoldMessenger.of(context).showSnackBar(
+              SnackBar(
+                content: Text(
+                  AppLocalizations.instance
+                      .translate('roast_setup_participant_data_loaded_from_qr'),
+                ),
+              ),
+            );
+          }
+        } else {
+          throw Exception('Missing name or publicKey in QR data');
+        }
+      } catch (e) {
+        LoggerWrapper.logError(
+          'ROASTWalletAddParticipantScreen',
+          '_scanQRCodeForParticipant',
+          'Failed to parse QR code: $e',
+        );
+
+        if (mounted) {
+          ScaffoldMessenger.of(context).showSnackBar(
+            SnackBar(
+              content: Text(
+                AppLocalizations.instance
+                    .translate('roast_setup_qr_invalid_format'),
+              ),
+            ),
+          );
+        }
+      }
+    }
+  }
+
   @override
   Widget build(BuildContext context) {
     return Scaffold(
@@ -106,6 +184,19 @@ class _ROASTWalletAddParticipantScreenState
                   const SizedBox(
                     height: 20,
                   ),
+                  Text(
+                    AppLocalizations.instance.translate(
+                      'roast_setup_group_member_manual_entry_hint',
+                    ),
+                    style: TextStyle(
+                      fontSize: 14,
+                      color: Theme.of(context).colorScheme.secondary,
+                      fontWeight: FontWeight.w500,
+                    ),
+                  ),
+                  const SizedBox(
+                    height: 15,
+                  ),
                   TextFormField(
                     textInputAction: TextInputAction.done,
                     key: _nameKey,
@@ -225,6 +316,15 @@ class _ROASTWalletAddParticipantScreenState
                       return null;
                     },
                   ),
+                  const SizedBox(
+                    height: 20,
+                  ),
+                  PeerButton(
+                    text: AppLocalizations.instance.translate(
+                      'roast_setup_scan_qr_participant',
+                    ),
+                    action: () => _scanQRCodeForParticipant(),
+                  ),
                 ],
               ),
             ),
@@ -234,5 +334,3 @@ class _ROASTWalletAddParticipantScreenState
     );
   }
 }
-
-// TODO scan QR code
diff --git a/lib/widgets/wallet/roast_group/setup_participants.dart b/lib/widgets/wallet/roast_group/setup_participants.dart
@@ -175,6 +175,7 @@ class _ROASTGroupSetupParticipantsState
   void _sharePubKey() async {
     // show bottom sheet
     await showModalBottomSheet(
+      context: context,
       shape: RoundedRectangleBorder(
         borderRadius: BorderRadius.circular(20.0),
       ),
@@ -186,7 +187,6 @@ class _ROASTGroupSetupParticipantsState
           action: () => _completeROASTClient(),
         );
       },
-      context: context,
     );
   }
 
@@ -336,5 +336,3 @@ class _ROASTGroupSetupParticipantsState
     );
   }
 }
-
-// TODO add member: scan QR code
diff --git a/lib/widgets/wallet/roast_group/setup_participants_share_pubkey_bottom_sheet.dart b/lib/widgets/wallet/roast_group/setup_participants_share_pubkey_bottom_sheet.dart
diff --git a/pubspec.lock b/pubspec.lock
diff --git a/pubspec.yaml b/pubspec.yaml
