pack-objects: release rev_info as appropriate

peff · peff · commit 85e616532bc1 · 2026-01-01T06:44:32.000-05:00
These seem to cause leaks with the prio_queue, but really, I'm surprised
it wasn't doing so before (I guess because we consumed everything in the
revs-&gt;commits list?). But this should probably be a preparatory patch.
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
@@ -3954,6 +3954,7 @@ static void read_stdin_packs(enum stdin_packs_mode mode, int rev_list_unpacked)
 			   stdin_packs_found_nr);
 	trace2_data_intmax("pack-objects", the_repository, "stdin_packs_hints",
 			   stdin_packs_hints_nr);
+	release_revisions(&revs);
 }
 
 static void add_cruft_object_entry(const struct object_id *oid, enum object_type type,
@@ -4117,6 +4118,7 @@ static void enumerate_and_traverse_cruft_objects(struct string_list *fresh_packs
 	traverse_commit_list(&revs, show_cruft_commit, show_cruft_object, NULL);
 
 	stop_progress(&progress_state);
+	release_revisions(&revs);
 }
 
 static void read_cruft_objects(void)

Original file line number	Diff line number	Diff line change
`@@ -3954,6 +3954,7 @@ static void read_stdin_packs(enum stdin_packs_mode mode, int rev_list_unpacked)`
`3954`	`3954`	`stdin_packs_found_nr);`
`3955`	`3955`	`trace2_data_intmax("pack-objects", the_repository, "stdin_packs_hints",`
`3956`	`3956`	`stdin_packs_hints_nr);`
	`3957`	`+ release_revisions(&revs);`
`3957`	`3958`	`}`
`3958`	`3959`
`3959`	`3960`	`static void add_cruft_object_entry(const struct object_id *oid, enum object_type type,`
`@@ -4117,6 +4118,7 @@ static void enumerate_and_traverse_cruft_objects(struct string_list *fresh_packs`
`4117`	`4118`	`traverse_commit_list(&revs, show_cruft_commit, show_cruft_object, NULL);`
`4118`	`4119`
`4119`	`4120`	`stop_progress(&progress_state);`
	`4121`	`+ release_revisions(&revs);`
`4120`	`4122`	`}`
`4121`	`4123`
`4122`	`4124`	`static void read_cruft_objects(void)`