tighter refname parsing

Author: peff

builtin/update-ref.c

@@ -74,7 +74,7 @@ static char *parse_refname(const char **next)
 		return NULL;
 	}
 
-	if (check_refname_format(ref.buf, REFNAME_ALLOW_ONELEVEL))
+	if (check_refname_format(ref.buf, REFNAME_FULLY_QUALIFIED))
 		die("invalid ref format: %s", ref.buf);
 
 	return strbuf_detach(&ref, NULL);
@@ -309,7 +309,7 @@ static void parse_cmd_symref_update(struct ref_transaction *transaction,
 
 			have_old_oid = 1;
 		} else if (!strcmp(old_arg, "ref")) {
-			if (check_refname_format(old_target, REFNAME_ALLOW_ONELEVEL))
+			if (check_refname_format(old_target, REFNAME_FULLY_QUALIFIED))
 				die("symref-update %s: invalid ref: %s", refname, old_target);
 		} else {
 			die("symref-update %s: invalid arg '%s' for old value", refname, old_arg);

t/t1400-update-ref.sh

@@ -2442,4 +2442,12 @@ test_expect_success 'dangling symref overwritten without old oid' '
 	test_must_fail git rev-parse --verify refs/heads/does-not-exist
 '
 
+test_expect_success 'update-ref validates refs as fully qualified' '
+	git symbolic-ref refs/heads/valid refs/heads/one &&
+	test_must_fail git update-ref --no-deref --stdin <<-\EOF 2>err &&
+	symref-update refs/heads/valid refs/heads/two ref invalid-at-root
+	EOF
+	test_grep "invalid ref: invalid-at-root" err
+'
+
 test_done