replaced LABELS_LEFT with DISPLAY_ONLY (#238)

samhere06 · mohas22 · web-flow · commit 0d0559c27219 · 2024-12-03T17:36:30.000+05:30
Co-authored-by: mohas22 &lt;Sameer.Mohammed@pega.com&gt;
diff --git a/packages/angular-sdk-components/src/lib/_components/field/group/group.component.ts b/packages/angular-sdk-components/src/lib/_components/field/group/group.component.ts
@@ -73,12 +73,12 @@ export class GroupComponent implements OnInit {
       this.visibility$ = this.pConn$.getComputedVisibility();
     }
 
-    if (this.configProps$.displayMode === 'LABELS_LEFT') {
+    if (this.configProps$.displayMode === 'DISPLAY_ONLY') {
       if (this.configProps$.visibility === undefined) this.visibility$ = true;
 
       this.arChildren$.forEach(child => {
         const pConn = child.getPConnect();
-        pConn.setInheritedProp('displayMode', 'LABELS_LEFT');
+        pConn.setInheritedProp('displayMode', 'DISPLAY_ONLY');
         pConn.setInheritedProp('readOnly', true);
 
         return child;
diff --git a/packages/angular-sdk-components/src/lib/_components/field/scalar-list/scalar-list.component.ts b/packages/angular-sdk-components/src/lib/_components/field/scalar-list/scalar-list.component.ts
@@ -102,7 +102,7 @@ export class ScalarListComponent implements OnInit, OnDestroy {
           type: componentType,
           config: {
             value: scalarValue,
-            displayMode: 'LABELS_LEFT',
+            displayMode: 'DISPLAY_ONLY',
             label: this.label$,
             ...restProps,
             readOnly: true
@@ -113,7 +113,7 @@ export class ScalarListComponent implements OnInit, OnDestroy {
         {}
       ); // 2nd, 3rd, and 4th args empty string/object/null until typedef marked correctly as optional;
     });
-    this.isDisplayModeEnabled = ['LABELS_LEFT', 'STACKED_LARGE_VAL', 'DISPLAY_ONLY'].includes(this.displayMode$ as string);
+    this.isDisplayModeEnabled = ['STACKED_LARGE_VAL', 'DISPLAY_ONLY'].includes(this.displayMode$ as string);
     this.value$ = this.items;
   }
 }
diff --git a/packages/angular-sdk-components/src/lib/_components/infra/defer-load/defer-load.component.ts b/packages/angular-sdk-components/src/lib/_components/infra/defer-load/defer-load.component.ts
@@ -116,7 +116,7 @@ export class DeferLoadComponent implements OnInit, OnDestroy, OnChanges {
         }
       };
       const configObject = PCore.createPConnect(config);
-      configObject.getPConnect().setInheritedProp('displayMode', 'LABELS_LEFT');
+      configObject.getPConnect().setInheritedProp('displayMode', 'DISPLAY_ONLY');
       this.loadedPConn$ = ReferenceComponent.normalizePConn(configObject.getPConnect());
       this.componentName$ = this.loadedPConn$.getComponentName();
       if (this.deferLoadId) {
diff --git a/packages/angular-sdk-components/src/lib/_components/template/data-reference/data-reference.component.ts b/packages/angular-sdk-components/src/lib/_components/template/data-reference/data-reference.component.ts
@@ -113,7 +113,7 @@ export class DataReferenceComponent implements OnInit, OnDestroy {
     this.refList = this.rawViewMetadata.config.referenceList;
     this.canBeChangedInReviewMode = theConfigProps.allowAndPersistChangesInReviewMode && (displayAs === 'autocomplete' || displayAs === 'dropdown');
     // this.childrenToRender = this.children;
-    this.isDisplayModeEnabled = ['LABELS_LEFT', 'STACKED_LARGE_VAL'].includes(displayMode);
+    this.isDisplayModeEnabled = ['DISPLAY_ONLY', 'STACKED_LARGE_VAL'].includes(displayMode);
 
     if (this.firstChildMeta?.type !== 'Region') {
       this.firstChildPConnect = this.pConn$.getChildren()[0].getPConnect;
diff --git a/packages/angular-sdk-components/src/lib/_components/template/details-one-column/details-one-column.component.ts b/packages/angular-sdk-components/src/lib/_components/template/details-one-column/details-one-column.component.ts
@@ -70,7 +70,7 @@ export class DetailsOneColumnComponent implements OnInit, OnDestroy {
       });
     }
 
-    this.pConn$.setInheritedProp('displayMode', 'LABELS_LEFT');
+    this.pConn$.setInheritedProp('displayMode', 'DISPLAY_ONLY');
     this.pConn$.setInheritedProp('readOnly', true);
 
     const kids = this.pConn$.getChildren() as any[];
diff --git a/packages/angular-sdk-components/src/lib/_components/template/details-three-column/details-three-column.component.ts b/packages/angular-sdk-components/src/lib/_components/template/details-three-column/details-three-column.component.ts
@@ -75,7 +75,7 @@ export class DetailsThreeColumnComponent implements OnInit, OnDestroy {
       });
     }
 
-    this.pConn$.setInheritedProp('displayMode', 'LABELS_LEFT');
+    this.pConn$.setInheritedProp('displayMode', 'DISPLAY_ONLY');
     this.pConn$.setInheritedProp('readOnly', true);
 
     const kids = this.pConn$.getChildren() as any[];
diff --git a/packages/angular-sdk-components/src/lib/_components/template/details-two-column/details-two-column.component.ts b/packages/angular-sdk-components/src/lib/_components/template/details-two-column/details-two-column.component.ts
@@ -75,7 +75,7 @@ export class DetailsTwoColumnComponent implements OnInit, OnDestroy {
       });
     }
 
-    this.pConn$.setInheritedProp('displayMode', 'LABELS_LEFT');
+    this.pConn$.setInheritedProp('displayMode', 'DISPLAY_ONLY');
     this.pConn$.setInheritedProp('readOnly', true);
 
     const kids = this.pConn$.getChildren() as any[];
diff --git a/packages/angular-sdk-components/src/lib/_components/template/details-wide-narrow/details-wide-narrow.component.ts b/packages/angular-sdk-components/src/lib/_components/template/details-wide-narrow/details-wide-narrow.component.ts
@@ -71,7 +71,7 @@ export class DetailsWideNarrowComponent implements OnInit, OnDestroy {
       });
     }
 
-    this.pConn$.setInheritedProp('displayMode', 'LABELS_LEFT');
+    this.pConn$.setInheritedProp('displayMode', 'DISPLAY_ONLY');
     this.pConn$.setInheritedProp('readOnly', true);
 
     const kids = this.pConn$.getChildren() as any[];
diff --git a/packages/angular-sdk-components/src/lib/_components/template/details/details.component.ts b/packages/angular-sdk-components/src/lib/_components/template/details/details.component.ts
@@ -79,7 +79,7 @@ export class DetailsComponent implements OnInit, OnDestroy {
         if (theCompType === 'reference' || theCompType === 'group') {
           const configProps = thePConn.getConfigProps();
           configProps.readOnly = true;
-          configProps.displayMode = 'LABELS_LEFT';
+          configProps.displayMode = 'DISPLAY_ONLY';
           const propToUse = { ...thePConn.getInheritedProps() };
           configProps.label = propToUse?.label;
           const options = {
diff --git a/packages/angular-sdk-components/src/lib/_components/template/dynamic-tabs/dynamic-tabs.component.ts b/packages/angular-sdk-components/src/lib/_components/template/dynamic-tabs/dynamic-tabs.component.ts
@@ -59,7 +59,7 @@ export class DynamicTabsComponent implements OnInit, OnDestroy {
     const { tablabel } = this.pConn$.getComponentConfig();
     const tablabelProp = PCore.getAnnotationUtils().getPropertyName(tablabel);
 
-    this.pConn$.setInheritedProp('displayMode', 'LABELS_LEFT');
+    this.pConn$.setInheritedProp('displayMode', 'DISPLAY_ONLY');
     this.pConn$.setInheritedProp('readOnly', true);
 
     const referenceListData = this.pConn$.getValue(`${referenceList}.pxResults`, ''); // 2nd arg empty string until typedefs properly allow optional
diff --git a/packages/angular-sdk-components/src/lib/_components/template/field-group-template/field-group-template.component.ts b/packages/angular-sdk-components/src/lib/_components/template/field-group-template/field-group-template.component.ts
@@ -105,7 +105,7 @@ export class FieldGroupTemplateComponent implements OnInit, OnDestroy, OnChanges
 
     const renderMode = this.configProps$.renderMode;
     const displayMode = this.configProps$.displayMode;
-    this.readonlyMode = renderMode === 'ReadOnly' || displayMode === 'LABELS_LEFT';
+    this.readonlyMode = renderMode === 'ReadOnly' || displayMode === 'DISPLAY_ONLY';
     this.contextClass = this.configProps$.contextClass;
     const lookForChildInConfig = this.configProps$.lookForChildInConfig;
     this.heading = this.configProps$.heading ?? 'Row';
@@ -114,7 +114,7 @@ export class FieldGroupTemplateComponent implements OnInit, OnDestroy, OnChanges
     this.pageReference = `${this.pConn$.getPageReference()}${resolvedList}`;
     this.pConn$.setReferenceList(resolvedList);
     if (this.readonlyMode) {
-      this.pConn$.setInheritedProp('displayMode', 'LABELS_LEFT');
+      this.pConn$.setInheritedProp('displayMode', 'DISPLAY_ONLY');
     }
     this.referenceList = this.configProps$.referenceList;
     if (this.prevRefLength != this.referenceList.length) {
diff --git a/packages/angular-sdk-components/src/lib/_components/template/field-value-list/field-value-list.component.html b/packages/angular-sdk-components/src/lib/_components/template/field-value-list/field-value-list.component.html
@@ -1,4 +1,4 @@
-<div *ngIf="displayMode$ === 'LABELS_LEFT'; else STACKED_LARGE_VAL" class="psdk-container-labels-left">
+<div *ngIf="displayMode$ === 'DISPLAY_ONLY'; else STACKED_LARGE_VAL" class="psdk-container-labels-left">
   <div class="psdk-grid-label">{{ label$ }}</div>
   <div class="psdk-val-labels-left">
     <ng-container *ngTemplateOutlet="valueTemplate"></ng-container>
diff --git a/packages/angular-sdk-components/src/lib/_helpers/field-group-utils.ts b/packages/angular-sdk-components/src/lib/_helpers/field-group-utils.ts
@@ -41,8 +41,8 @@ export const buildView = (pConn, index, viewConfigPath) => {
   };
 
   const view = PCore.createPConnect(config);
-  if (pConn.getConfigProps()?.displayMode === 'LABELS_LEFT') {
-    view.getPConnect()?.setInheritedProp('displayMode', 'LABELS_LEFT');
+  if (pConn.getConfigProps()?.displayMode === 'DISPLAY_ONLY') {
+    view.getPConnect()?.setInheritedProp('displayMode', 'DISPLAY_ONLY');
   }
 
   return view;

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ export class DeferLoadComponent implements OnInit, OnDestroy, OnChanges {`
`116`	`116`	`}`
`117`	`117`	`};`
`118`	`118`	`const configObject = PCore.createPConnect(config);`
`119`		`- configObject.getPConnect().setInheritedProp('displayMode', 'LABELS_LEFT');`
	`119`	`+ configObject.getPConnect().setInheritedProp('displayMode', 'DISPLAY_ONLY');`
`120`	`120`	`this.loadedPConn$ = ReferenceComponent.normalizePConn(configObject.getPConnect());`
`121`	`121`	`this.componentName$ = this.loadedPConn$.getComponentName();`
`122`	`122`	`if (this.deferLoadId) {`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ export class DetailsOneColumnComponent implements OnInit, OnDestroy {`
`70`	`70`	`});`
`71`	`71`	`}`
`72`	`72`
`73`		`- this.pConn$.setInheritedProp('displayMode', 'LABELS_LEFT');`
	`73`	`+ this.pConn$.setInheritedProp('displayMode', 'DISPLAY_ONLY');`
`74`	`74`	`this.pConn$.setInheritedProp('readOnly', true);`
`75`	`75`
`76`	`76`	`const kids = this.pConn$.getChildren() as any[];`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export class DetailsThreeColumnComponent implements OnInit, OnDestroy {`
`75`	`75`	`});`
`76`	`76`	`}`
`77`	`77`
`78`		`- this.pConn$.setInheritedProp('displayMode', 'LABELS_LEFT');`
	`78`	`+ this.pConn$.setInheritedProp('displayMode', 'DISPLAY_ONLY');`
`79`	`79`	`this.pConn$.setInheritedProp('readOnly', true);`
`80`	`80`
`81`	`81`	`const kids = this.pConn$.getChildren() as any[];`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ export class DetailsWideNarrowComponent implements OnInit, OnDestroy {`
`71`	`71`	`});`
`72`	`72`	`}`
`73`	`73`
`74`		`- this.pConn$.setInheritedProp('displayMode', 'LABELS_LEFT');`
	`74`	`+ this.pConn$.setInheritedProp('displayMode', 'DISPLAY_ONLY');`
`75`	`75`	`this.pConn$.setInheritedProp('readOnly', true);`
`76`	`76`
`77`	`77`	`const kids = this.pConn$.getChildren() as any[];`