Removed PCore and some unnecessary declarations (#317)

Co-authored-by: Sharma <[email protected]>

Author: vishalshrm539

packages/angular-sdk-components/src/lib/_components/infra/navbar/navbar.component.ts

@@ -7,8 +7,6 @@ import { AngularPConnectData, AngularPConnectService } from '../../../_bridge/an
 import { ProgressSpinnerService } from '../../../_messages/progress-spinner.service';
 import { Utils } from '../../../_helpers/utils';
 
-declare const window: any;
-
 interface NavBarProps {
   // If any, enter additional props that only exist on this component
   showAppName?: boolean;

packages/angular-sdk-components/src/lib/_components/template/list-view/list-view.component.ts

@@ -23,8 +23,6 @@ import { formatters } from '../../../_helpers/formatters/format-utils';
 
 import { init } from './listViewHelpers';
 
-declare const window: any;
-
 const SELECTION_MODE = { SINGLE: 'single', MULTI: 'multi' };
 
 interface ListViewProps {

packages/angular-sdk-components/src/lib/_components/template/list-view/listViewHelpers.ts

@@ -1,8 +1,5 @@
 import { getContext, readContextResponse } from './utils';
 
-// Remove this and use "real" PCore type once .d.ts is fixed (currently shows 1 error)
-declare const PCore: any;
-
 export function init(props) {
   const {
     referenceList,
@@ -25,9 +22,9 @@ export function init(props) {
   let selectionCountThreshold;
 
   // promise to fetch metadata
-  const metaDataPromise = PCore.getAnalyticsUtils().getDataViewMetadata(referenceList, showDynamicFields);
+  const metaDataPromise = PCore.getAnalyticsUtils().getDataViewMetadata(referenceList, showDynamicFields, null);
 
-  const promisesArray = [metaDataPromise];
+  const promisesArray: any = [metaDataPromise];
 
   // promise to fetch report configured columns
   const reportColumnsPromise = PCore.getAnalyticsUtils()

packages/angular-sdk-components/src/lib/_components/template/list-view/utils.ts

@@ -1,8 +1,5 @@
 import { getDefaultViewMeta } from './DefaultViewMeta';
 
-// Remove this and use "real" PCore type once .d.ts is fixed (currently shows 5 errors)
-declare const PCore: any;
-
 const USER_REFERENCE = 'UserReference';
 const PAGE = '!P!';
 const PAGELIST = '!PL!';
@@ -121,7 +118,7 @@ export const isPageListInPath = (propertyName, currentClassID) => {
     return false;
   }
   const [first, ...rest] = propertyName.split('.');
-  const metadata = PCore.getMetadataUtils().getPropertyMetadata(first, currentClassID);
+  const metadata: any = PCore.getMetadataUtils().getPropertyMetadata(first, currentClassID);
   if (metadata?.type === 'Page List') {
     return true;
   }
@@ -205,7 +202,7 @@ export function getConfigEmbeddedFieldsMeta(configFields, classID) {
       if (value.includes('[')) {
         value = value.substring(0, value.indexOf('[')) + value.substring(value.indexOf(']') + 1);
       }
-      const meta = PCore.getMetadataUtils().getEmbeddedPropertyMetadata(value, classID);
+      const meta: any = PCore.getMetadataUtils().getEmbeddedPropertyMetadata(value, classID);
       meta.fieldID = field;
       configEmbeddedFieldsMeta.push(meta);
     }

packages/angular-sdk-components/src/lib/_components/template/simple-table-manual/simple-table-manual.component.ts

@@ -21,8 +21,6 @@ import { evaluateAllowRowAction } from '../utils';
 import { Utils } from '../../../_helpers/utils';
 import { getSeconds } from '../../../_helpers/common';
 
-declare const window: any;
-
 interface SimpleTableManualProps {
   // If any, enter additional props that only exist on this component
   visibility?: boolean;

packages/angular-sdk-components/src/lib/_components/widget/feed-container/feed-container.component.ts

@@ -9,8 +9,6 @@ import isEqual from 'fast-deep-equal';
 import { AngularPConnectData, AngularPConnectService } from '../../../_bridge/angular-pconnect';
 import { Utils } from '../../../_helpers/utils';
 
-declare const window: any;
-
 @Component({
   selector: 'app-feed-container',
   templateUrl: './feed-container.component.html',