fix: ensure proper handling of attachment updates and error management in AttachmentComponent

Author: tumms2021389

packages/angular-sdk-components/src/lib/_components/infra/assignment/assignment.component.ts

@@ -435,12 +435,13 @@ export class AssignmentComponent implements OnInit, OnDestroy, OnChanges {
           const finishPromise = this.finishAssignment(this.itemKey$); // JA - was itemID but Nebula/Constellation uses itemKey
           finishPromise
             .then(() => {
-              this.psService.sendMessage(false);
               this.updateChanges();
             })
             .catch(() => {
-              this.psService.sendMessage(false);
               this.snackBarRef = this.snackBar.open(`${this.localizedVal('Submit failed!', this.localeCategory)}`, 'Ok');
+            })
+            .finally(() => {
+              this.psService.sendMessage(false);
             });
           break;
 
@@ -450,8 +451,10 @@ export class AssignmentComponent implements OnInit, OnDestroy, OnChanges {
           approvePromise
             .then(() => {})
             .catch(() => {
-              this.psService.sendMessage(false);
               this.snackBarRef = this.snackBar.open(`${this.localizedVal('Approve failed!', this.localeCategory)}`, 'Ok');
+            })
+            .finally(() => {
+              this.psService.sendMessage(false);
             });
 
           break;

packages/angular-sdk-components/src/lib/_components/widget/attachment/attachment.component.ts

@@ -156,8 +156,16 @@ export class AttachmentComponent implements OnInit, OnDestroy {
     this.displayMode = displayMode;
     this.isMultiAttachmentInInlineEditTable = isTableFormatter && allowMultiple && editMode === 'tableRows';
 
+    const rawValue = this.pConn$.getComponentConfig().value;
+    const isAttachmentAnnotationPresent = typeof rawValue === 'object' ? false : rawValue?.includes('@ATTACHMENT');
+    const { attachments, isOldAttachment } = isAttachmentAnnotationPresent ? value : PCore.getAttachmentUtils().prepareAttachmentData(value);
+    this.isOldAttachment = isOldAttachment;
+    this.attachments = attachments;
+
     // update the attachments shown in the UI
-    this.updateAttachments();
+    if (this.attachments.length) {
+      this.updateAttachments();
+    }
   }
 
   updateAttachments() {
@@ -330,6 +338,7 @@ export class AttachmentComponent implements OnInit, OnDestroy {
   }
 
   populateErrorAndUpdateRedux(file) {
+    console.log('populateErrorAndUpdateRedux');
     const fieldName = (this.pConn$.getStateProps() as any).value;
     // set errors to property to block submit even on errors in file upload
     PCore.getMessageManager().addMessages({
@@ -439,12 +448,13 @@ export class AttachmentComponent implements OnInit, OnDestroy {
           if (this.filesWithError?.length === 0) {
             clearFieldErrorMessages(this.pConn$);
           }
-
-          this.actionSequencer.deRegisterBlockingAction(this.contextName).catch(() => {});
         }
+
+        this.actionSequencer.deRegisterBlockingAction(this.contextName).catch(() => {});
       })
       .catch(error => {
         console.log(error);
+        this.actionSequencer.cancelDeferredActionsOnError(this.contextName);
       });
   }