Skip to content

Commit a28a661

Browse files
authored
fix: Two column layout fix (#383)
1 parent d5f4d7d commit a28a661

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

packages/angular-sdk-components/src/lib/_components/designSystemExtension/banner/banner.component.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
column-gap: calc(2 * 0.5rem);
2929
row-gap: calc(2 * 0.5rem);
3030
align-items: start;
31+
32+
& > *:nth-child(2) {
33+
min-width: 0;
34+
}
3135
}
3236

3337
.background-image-style {

packages/angular-sdk-components/src/lib/_components/infra/view/view.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ export class ViewComponent implements OnInit, OnDestroy, OnChanges {
162162
this.showLabel$ = this.configProps$.showLabel || isDetailsTemplate(this.templateName$) || this.showLabel$;
163163
// label & showLabel within inheritedProps takes precedence over configProps
164164
this.label$ = this.inheritedProps$.label || this.label$;
165-
this.showLabel$ = this.inheritedProps$.showLabel || this.showLabel$;
166165
// children may have a 'reference' so normalize the children array
167166
this.arChildren$ = ReferenceComponent.normalizePConnArray(this.pConn$.getChildren());
168167
this.visibility$ = this.configProps$.visibility ?? this.visibility$;

packages/angular-sdk-components/src/lib/_components/template/default-page/default-page.component.html

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,11 @@ <h1 *ngIf="title">{{ title }}</h1>
2424
'psdk-grid-filter-narrow-wide': this.layout$ === 'narrow-wide'
2525
}"
2626
>
27-
<div>
28-
<component-mapper
29-
*ngFor="let child of arChildren$"
30-
[name]="child.getPConnect().getComponentName()"
31-
[props]="{ pConn$: child.getPConnect() }"
32-
></component-mapper>
33-
</div>
27+
<component-mapper
28+
*ngFor="let child of arChildren$"
29+
[name]="child.getPConnect().getComponentName()"
30+
[props]="{ pConn$: child.getPConnect() }"
31+
></component-mapper>
3432
</div>
3533
</div>
3634
</ng-template>

0 commit comments

Comments
 (0)