Skip to content

Commit ac85a5e

Browse files
authored
fix: Label should not be displayed for listview template (#390)
1 parent c8cbf21 commit ac85a5e

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

packages/angular-sdk-components/src/lib/_components/infra/view/view.component.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { getAllFields } from '../../template/utils';
77
import { ReferenceComponent } from '../reference/reference.component';
88
import { ComponentMapperComponent } from '../../../_bridge/component-mapper/component-mapper.component';
99

10-
const NO_HEADER_TEMPLATES = ['SubTabs', 'SimpleTable', 'Confirmation', 'DynamicTabs', 'DetailsSubTabs'];
10+
const NO_HEADER_TEMPLATES = ['SubTabs', 'SimpleTable', 'Confirmation', 'DynamicTabs', 'DetailsSubTabs', 'ListView'];
1111
const DETAILS_TEMPLATES = [
1212
'Details',
1313
'DetailsFields',
@@ -158,10 +158,9 @@ export class ViewComponent implements OnInit, OnDestroy, OnChanges {
158158

159159
this.templateName$ = this.configProps$.template || '';
160160
this.title$ = this.configProps$.title || '';
161-
this.label$ = this.configProps$.label || '';
162-
this.showLabel$ = this.configProps$.showLabel || isDetailsTemplate(this.templateName$) || this.showLabel$;
163161
// label & showLabel within inheritedProps takes precedence over configProps
164-
this.label$ = this.inheritedProps$.label || this.label$;
162+
this.label$ = this.inheritedProps$.label || this.configProps$.label || '';
163+
this.showLabel$ = this.inheritedProps$.showLabel || this.configProps$.showLabel || isDetailsTemplate(this.templateName$);
165164
// children may have a 'reference' so normalize the children array
166165
this.arChildren$ = ReferenceComponent.normalizePConnArray(this.pConn$.getChildren());
167166
this.visibility$ = this.configProps$.visibility ?? this.visibility$;

0 commit comments

Comments
 (0)