Skip to content

Commit d5718de

Browse files
committed
removed unnecessary code in case view
1 parent 7bb2763 commit d5718de

File tree

3 files changed

+13
-25
lines changed

3 files changed

+13
-25
lines changed

packages/angular-sdk-components/src/lib/_bridge/component-mapper/component-mapper.component.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,14 @@ import { CommonModule } from '@angular/common';
33
import { getComponentFromMap } from '../helpers/sdk_component_map';
44
import { ErrorBoundaryComponent } from '../../_components/infra/error-boundary/error-boundary.component';
55

6-
const componentsRequireDisplayOnlyFAProp: string[] = [
7-
'HybridViewContainer',
8-
'ModalViewContainer',
9-
'ViewContainer',
10-
'RootContainer',
11-
'View',
12-
'CaseView'
13-
];
6+
const componentsRequireDisplayOnlyFAProp: string[] = ['HybridViewContainer', 'ModalViewContainer', 'ViewContainer', 'RootContainer', 'View'];
147

158
@Component({
169
selector: 'component-mapper',
1710
templateUrl: './component-mapper.component.html',
1811
styleUrls: ['./component-mapper.component.scss'],
1912
standalone: true,
20-
imports: [CommonModule, ErrorBoundaryComponent]
13+
imports: [CommonModule]
2114
})
2215
export class ComponentMapperComponent implements OnInit, OnDestroy, OnChanges {
2316
@ViewChild('dynamicComponent', { read: ViewContainerRef, static: true })

packages/angular-sdk-components/src/lib/_components/template/case-view/case-view.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="psdk-case-view" id="case-view">
2-
<div *ngIf="!displayOnlyFA$" class="psdk-case-view-info">
2+
<div class="psdk-case-view-info">
33
<mat-toolbar color="primary" class="psdk-case-view-toolbar">
44
<mat-toolbar-row style="padding-left: 1rem">
55
<div class="psdk-case-icon-div">
@@ -47,7 +47,7 @@ <h1 id="case-name">{{ heading$ }}</h1>
4747
></component-mapper>
4848
</div>
4949
<div class="psdk-case-view-main">
50-
<div *ngIf="!displayOnlyFA$">
50+
<div>
5151
<div *ngFor="let kid of arChildren$">
5252
<div
5353
*ngIf="
@@ -73,11 +73,11 @@ <h1 id="case-name">{{ heading$ }}</h1>
7373
</div>
7474
</div>
7575

76-
<div *ngIf="!displayOnlyFA$">
76+
<div>
7777
<component-mapper name="DeferLoad" [props]="{ pConn$, loadData$: tabData$, name: tabData$?.config?.name }"></component-mapper>
7878
</div>
7979
</div>
80-
<div *ngIf="!displayOnlyFA$">
80+
<div>
8181
<div *ngIf="arChildren$" class="psdk-case-view-utilities">
8282
<div *ngFor="let kid of arChildren$">
8383
<div *ngIf="kid.getPConnect().getRawMetadata()?.type.toLowerCase() == 'region' && kid.getPConnect().getRawMetadata()?.name == 'Utilities'">

packages/angular-sdk-components/src/lib/_components/template/case-view/case-view.component.ts

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ interface CaseViewProps {
2727
export class CaseViewComponent implements OnInit, OnDestroy {
2828
@Input() pConn$: typeof PConnect;
2929
@Input() formGroup$: FormGroup;
30-
@Input() displayOnlyFA$: boolean;
3130

3231
// Used with AngularPConnect
3332
angularPConnectData: AngularPConnectData = {};
@@ -161,19 +160,15 @@ export class CaseViewComponent implements OnInit, OnDestroy {
161160

162161
this.svgCase$ = this.utils.getImageSrc(this.configProps$.icon, this.utils.getSDKStaticContentUrl());
163162

164-
// this.utils.consoleKidDump(this.pConn$);
165-
166-
if (!this.displayOnlyFA$) {
167-
for (const kid of this.arChildren$) {
168-
const kidPConn = kid.getPConnect();
169-
if (kidPConn.getRawMetadata().name == 'Tabs') {
170-
this.mainTabs = kid;
171-
this.mainTabData = this.mainTabs.getPConnect().getChildren();
172-
}
163+
for (const kid of this.arChildren$) {
164+
const kidPConn = kid.getPConnect();
165+
if (kidPConn.getRawMetadata().name == 'Tabs') {
166+
this.mainTabs = kid;
167+
this.mainTabData = this.mainTabs.getPConnect().getChildren();
173168
}
174-
175-
this.generateTabsData();
176169
}
170+
171+
this.generateTabsData();
177172
}
178173

179174
generateTabsData() {

0 commit comments

Comments
 (0)