TASK-1828883: few minor review fixes

Author: marekpelc-pega

core/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/core/components/containers/ModalViewContainer.kt

@@ -6,15 +6,16 @@ import androidx.compose.runtime.setValue
 import com.pega.constellation.sdk.kmp.core.api.ComponentContext
 import com.pega.constellation.sdk.kmp.core.api.ComponentEvent
 import com.pega.constellation.sdk.kmp.core.api.ComponentId
+import com.pega.constellation.sdk.kmp.core.api.HideableComponent
 import com.pega.constellation.sdk.kmp.core.components.getBoolean
 import com.pega.constellation.sdk.kmp.core.components.getJSONArray
 import com.pega.constellation.sdk.kmp.core.components.getString
 import com.pega.constellation.sdk.kmp.core.components.widgets.AlertBannerComponent
 import com.pega.constellation.sdk.kmp.core.internal.ComponentManagerImpl.Companion.getComponentTyped
 import kotlinx.serialization.json.JsonObject
 
-class ModalViewContainerComponent(context: ComponentContext) : ContainerComponent(context) {
-    var visible by mutableStateOf(false)
+class ModalViewContainerComponent(context: ComponentContext) : ContainerComponent(context), HideableComponent {
+    override var visible by mutableStateOf(false)
         private set
     var title by mutableStateOf("")
         private set

core/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/core/components/containers/SimpleTableManual.kt

@@ -8,14 +8,15 @@ import com.pega.constellation.sdk.kmp.core.api.Component
 import com.pega.constellation.sdk.kmp.core.api.ComponentContext
 import com.pega.constellation.sdk.kmp.core.api.ComponentEvent
 import com.pega.constellation.sdk.kmp.core.api.ComponentId
+import com.pega.constellation.sdk.kmp.core.api.HideableComponent
 import com.pega.constellation.sdk.kmp.core.components.getBoolean
 import com.pega.constellation.sdk.kmp.core.components.getJSONArray
 import com.pega.constellation.sdk.kmp.core.components.getString
 import kotlinx.serialization.json.JsonObject
 import kotlinx.serialization.json.jsonObject
 
-class SimpleTableManualComponent(context: ComponentContext) : BaseComponent(context) {
-    var visible by mutableStateOf(false)
+class SimpleTableManualComponent(context: ComponentContext) : BaseComponent(context), HideableComponent {
+    override var visible by mutableStateOf(false)
         private set
     var label: String by mutableStateOf("")
         private set
@@ -48,7 +49,6 @@ class SimpleTableManualComponent(context: ComponentContext) : BaseComponent(cont
         return columnsJsonArray.mapWithIndex { getString(it) }
     }
 
-
     private fun getRows(props: JsonObject): List<Row> =
         props.getJSONArray("rows").map { jsonElement ->
             val rowJsonObject = jsonElement.jsonObject

scripts/dxcomponents/components/containers/root-container.component.js

@@ -1,5 +1,5 @@
-import {Utils} from "../../helpers/utils.js";
-import {BaseComponent} from "../base.component.js";
+import { Utils } from "../../helpers/utils.js";
+import { BaseComponent } from "../base.component.js";
 
 const options = {context: "app"};
 const TAG = "[RootContainerComponent]";

scripts/dxcomponents/components/containers/templates/field-group-template.component.js

@@ -1,6 +1,6 @@
 import { Utils } from "../../../helpers/utils.js";
 import { BaseComponent } from "../../base.component.js";
-import {evaluateAllowRowAction, getReferenceList} from "./template-utils.js";
+import { evaluateAllowRowAction, getReferenceList } from "./template-utils.js";
 
 export class FieldGroupTemplateComponent extends BaseComponent {
     jsComponentPConnectData = {};

scripts/dxcomponents/components/containers/templates/simple-table-manual.component.js

@@ -1,5 +1,4 @@
-import {BaseComponent} from "../../base.component.js";
-import {Utils} from "../../../helpers/utils.js";
+import { BaseComponent } from "../../base.component.js";
 import {
     buildFieldsForTable,
     evaluateAllowRowAction,
@@ -40,7 +39,6 @@ export class SimpleTableManualComponent extends BaseComponent {
     constructor(componentsManager, pConn) {
         super(componentsManager, pConn);
         this.type = "SimpleTableManual";
-        this.utils = new Utils();
     }
 
     init() {
@@ -112,7 +110,7 @@ export class SimpleTableManualComponent extends BaseComponent {
         this.referenceListStr = getContext(this.pConn).referenceListStr;
         this.props.label = labelProp || propertyLabel;
         this.targetClassLabel = targetClassLabel;
-        this.props.addButtonLabel =  targetClassLabel ? `+ Add ${targetClassLabel}` : "+ Add";
+        this.props.addButtonLabel = targetClassLabel ? `+ Add ${targetClassLabel}` : "+ Add";
         this.referenceList = referenceList;
         this.contextClass = this.#getContextClass(configProps);
 
@@ -142,7 +140,7 @@ export class SimpleTableManualComponent extends BaseComponent {
 
         this.props.columnLabels = this.#getColumnLabels(fieldDefs, resolvedFields);
 
-        if((!this.#listsEqual(this.prevReferenceList, this.referenceList))) {
+        if ((!this.#listsEqual(this.prevReferenceList, this.referenceList))) {
             this.#buildRows(rawFields, editableMode, conditions.allowDeleteRow, allowRowDelete, conditions.allowEditRow, allowRowEdit);
         }
         this.prevReferenceList = this.referenceList;

scripts/dxcomponents/components/containers/templates/simple-table.component.js

@@ -1,6 +1,5 @@
-import {Utils} from "../../../helpers/utils.js";
-import {BaseComponent} from "../../base.component.js";
-import {getContext} from "./template-utils.js";
+import { Utils } from "../../../helpers/utils.js";
+import { BaseComponent } from "../../base.component.js";
 
 const TAG = "[SimpleTableComponent]";
 

scripts/dxcomponents/components/containers/templates/template-utils.js

@@ -71,7 +71,7 @@ export function getContext(thePConn) {
     };
 }
 
-function updateFieldLabels (fields, configFields, primaryFieldsViewIndex, pConnect, options) {
+function updateFieldLabels(fields, configFields, primaryFieldsViewIndex, pConnect, options) {
     const labelsOfFields = [];
     const { columnsRawConfig = [] } = options;
     fields.forEach((field, idx) => {

ui-renderer-cmp/build.gradle.kts

@@ -39,7 +39,7 @@ kotlin {
                 implementation(libs.kotlinx.datetime)
                 implementation(libs.ksoup.http.parser)
                 implementation(libs.table.m3)
-                implementation("com.mohamedrejeb.dnd:compose-dnd:0.3.0")
+                implementation(libs.compose.dnd)
             }
         }
     }