TASK-1828883: cleaning simple-table.component.js

Author: marekpelc-pega

core/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/core/components/containers/ModalViewContainer.kt

@@ -15,6 +15,7 @@ import kotlinx.serialization.json.JsonObject
 
 class ModalViewContainerComponent(context: ComponentContext) : ContainerComponent(context) {
     var visible by mutableStateOf(false)
+        private set
     var title by mutableStateOf("")
         private set
     var cancelButtonLabel by mutableStateOf("")

scripts/dxcomponents/components/containers/templates/simple-table.component.js

@@ -60,101 +60,31 @@ export class SimpleTableComponent extends BaseComponent {
             this.props.visible = this.utils.getBooleanValue(configProps.visibility);
         }
 
-        const {
-            multiRecordDisplayAs,
-            label: labelProp,
-            propertyLabel,
-            displayMode,
-            fieldMetadata,
-            hideLabel,
-            parameters,
-            isDataObject,
-            type,
-            ruleClass,
-            authorContext,
-            name
-        } = configProps;
-        const label = labelProp || propertyLabel;
+        const { multiRecordDisplayAs, fieldMetadata } = configProps;
 
-        let {contextClass} = configProps;
+        let { contextClass } = configProps;
         if (!contextClass) {
             let listName = this.pConn.getComponentConfig().referenceList;
             listName = PCore.getAnnotationUtils().getPropertyName(listName);
             contextClass = this.pConn.getFieldMetadata(listName)?.pageClass;
         }
-        if (multiRecordDisplayAs === "fieldGroup") { // table, simpleTable
-            const fieldGroupProps = {...configProps, contextClass};
+        if (multiRecordDisplayAs === "fieldGroup") {
+            const fieldGroupProps = { ...configProps, contextClass };
             this.childComponent = this.componentsManager.upsert(this.childComponent, "FieldGroupTemplate", [
                 this.pConn,
                 fieldGroupProps,
             ]);
             this.#sendPropsUpdate();
         } else if (fieldMetadata && fieldMetadata.type === 'Page List' && fieldMetadata.dataRetrievalType === 'refer') {
-            const {
-                children: [{children: rawFields}],
-                parameters: rawParams
-            } = (this.pConn.getRawMetadata()).config;
-            const isDisplayModeEnabled = displayMode === 'DISPLAY_ONLY';
-            const propsToUse = {label, ...this.pConn.getInheritedProps()};
-            if (isDisplayModeEnabled && hideLabel) {
-                propsToUse.label = '';
-            }
-
-            const metaForListView = buildMetaForListView(
-                fieldMetadata,
-                rawFields,
-                type,
-                ruleClass,
-                name,
-                propsToUse.label,
-                isDataObject,
-                parameters // resolved params
-            );
-
-            const metaForPConnect = JSON.parse(JSON.stringify(metaForListView));
-            // @ts-ignore - PCore.getMetadataUtils().getPropertyMetadata - An argument for 'currentClassID' was not provided.
-            metaForPConnect.config.parameters = rawParams ?? PCore.getMetadataUtils().getPropertyMetadata(name)?.datasource?.parameters;
-
-            const {referenceListStr: referenceList} = getContext(this.pConn);
-            let requiredContextForQueryInDisplayMode = {};
-            if (isDisplayModeEnabled) {
-                requiredContextForQueryInDisplayMode = {
-                    referenceList
-                };
-            }
-            const options = {
-                context: this.pConn.getContextName(),
-                pageReference: this.pConn.getPageReference(),
-                ...requiredContextForQueryInDisplayMode
-            };
-
-            const listViewPConn = PCore.createPConnect({meta: metaForPConnect, options}).getPConnect();
-
-            const listViewProps = {
-                ...metaForListView.config,
-                displayMode,
-                fieldName: authorContext
-            };
-            // if (multiRecordDisplayAs === "simpleTable") {
-            //
-            // }
-            this.childComponent = this.componentsManager.upsert(this.childComponent, "ListView", [
-                listViewPConn,
-                listViewProps,
-            ]);
-            this.#sendPropsUpdate();
+            console.warn(TAG, 'Displaying ListView in SimpleTable is not supported yet.');
         } else {
-            // console.warn(
-            //     TAG,
-            //     `Unsupported display mode: ${multiRecordDisplayAs}. ListView and SimpleTableManual are not supported yet.`
-            // );
             this.childComponent = this.componentsManager.upsert(this.childComponent, "SimpleTableManual", [this.pConn]);
             this.#sendPropsUpdate();
         }
     }
 
     onEvent(event) {
-        // TODO: remove optional call when other modes are implemented so that child component is always defined
+        // TODO: remove optional call when all other modes are implemented so that child component is always defined
         this.childComponent?.onEvent(event);
     }
 

scripts/dxcomponents/components/containers/templates/template-utils.js

@@ -1,5 +1,4 @@
 export const TABLE_CELL = 'SdkRenderer';
-export const DELETE_ICON = 'DeleteIcon';
 const PRIMARY_FIELDS = 'pyPrimaryFields';
 
 export function getReferenceList(pConn) {

ui-renderer-cmp/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/ui/renderer/cmp/containers/ModalViewContainerRenderer.kt

@@ -33,7 +33,7 @@ class ModalViewContainerRenderer : ComponentRenderer<ModalViewContainerComponent
                 onDismissRequest = {
                     onCancelClick()
                 }
-                ) {
+            ) {
                 Card(
                     modifier = Modifier.fillMaxWidth(),
                 ) {