ISSUE-138440: calling webView.evaluateJavascript in AndroidWebViewEngine.kt on main thread using activity lifecycleScope

Author: marekpelc-pega

core/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/core/components/containers/ListViewComponent.kt

@@ -37,8 +37,6 @@ class ListViewComponent(context: ComponentContext) : BaseComponent(context) {
     var items by mutableStateOf(emptyList<Item>())
         private set
     private var selectedItemIndexToSubmit: Int? = null
-    var updateIndex by mutableStateOf(0L)
-        private set
 
     override fun applyProps(props: JsonObject) {
         label = props.getString("label")
@@ -53,7 +51,7 @@ class ListViewComponent(context: ComponentContext) : BaseComponent(context) {
             .map {
                 Item(it.toFoldedItemContent(emptyMap(), ""))
             }
-        ++updateIndex
+        checkAutoSubmit()
     }
 
     fun onItemSelected(itemIndex: Int) {

engine-webview/src/androidMain/kotlin/com/pega/constellation/sdk/kmp/engine/webview/android/AndroidWebViewEngine.kt

@@ -36,6 +36,8 @@ import com.pega.constellation.sdk.kmp.engine.webview.android.internal.SdkWebView
 import com.pega.constellation.sdk.kmp.engine.webview.common.EngineConfiguration
 import com.pega.constellation.sdk.kmp.engine.webview.common.InternalError
 import com.pega.constellation.sdk.kmp.engine.webview.common.JsError
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.launch
 
 import okhttp3.OkHttpClient
 import org.json.JSONObject
@@ -44,7 +46,8 @@ import java.util.concurrent.TimeUnit
 class AndroidWebViewEngine(
     private val context: Context,
     private val okHttpClient: OkHttpClient,
-    private val nonDxOkHttpClient: OkHttpClient = defaultHttpClient()
+    private val nonDxOkHttpClient: OkHttpClient = defaultHttpClient(),
+    private val lifecycleScope: CoroutineScope
 ) : ConstellationSdkEngine {
 
     private lateinit var config: ConstellationSdkConfig
@@ -133,7 +136,9 @@ class AndroidWebViewEngine(
             put("eventData", JSONObject(event.eventData))
         }
         val script = "window.sendEventToComponent('${id.id}', '$eventJson')"
-        webView.evaluateJavascript(script, null)
+        this.lifecycleScope.launch {
+            webView.evaluateJavascript(script, null)
+        }
     }
 
     @SuppressLint("SetJavaScriptEnabled")

samples/android-cmp-app/src/androidInstrumentedTest/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/ComposeTest.kt

@@ -42,7 +42,7 @@ abstract class ComposeTest(
     private val context = instrumentation.targetContext
     private val authManager = AuthManager(scope, FakeAuthFlowFactory(), FakeTokenStore(mode.token))
     private val httpClient = buildHttpClient(authManager)
-    private val engine = AndroidWebViewEngine(context, httpClient, httpClient)
+    private val engine = AndroidWebViewEngine(context, httpClient, httpClient, scope)
 
     @BeforeTest
     fun setUp() {

samples/android-cmp-app/src/androidMain/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/MediaCoActivity.kt

@@ -28,7 +28,11 @@ class MediaCoActivity : ComponentActivity() {
         val authFlowFactory = AndroidCodeAuthFlowFactory().also { it.registerActivity(this) }
         val authManager = createAuthManager(authFlowFactory)
 
-        val engine = AndroidWebViewEngine(this, buildHttpClient(authManager))
+        val engine = AndroidWebViewEngine(
+            context = this,
+            okHttpClient = buildHttpClient(authManager),
+            lifecycleScope = this.lifecycleScope
+        )
         Injector.init(authManager, engine)
         AppContext.init(this)
 

samples/android-compose-app/src/main/java/com/pega/constellation/sdk/kmp/samples/androidcomposeapp/AndroidComposeActivity.kt

@@ -19,6 +19,7 @@ import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.unit.dp
+import androidx.lifecycle.lifecycleScope
 import com.pega.constellation.sdk.kmp.core.ConstellationSdk
 import com.pega.constellation.sdk.kmp.core.ConstellationSdk.State
 import com.pega.constellation.sdk.kmp.core.ConstellationSdk.State.Cancelled
@@ -75,7 +76,11 @@ class AndroidComposeActivity : ComponentActivity() {
             debuggable = true
         )
         val caseClassName = AndroidSDKConfig.PEGA_CASE_CLASS_NAME
-        val engine = AndroidWebViewEngine(this, buildHttpClient())
+        val engine = AndroidWebViewEngine(
+            context = this,
+            okHttpClient = buildHttpClient(),
+            lifecycleScope = this.lifecycleScope
+        )
         sdk = ConstellationSdk.create(config, engine)
         sdk.createCase(caseClassName)
     }

test/src/androidDeviceTest/kotlin/com/pega/constellation/sdk/kmp/test/ConstellationSdkTest.kt

@@ -5,19 +5,23 @@ import androidx.test.ext.junit.runners.AndroidJUnit4
 import com.pega.constellation.sdk.kmp.engine.webview.android.AndroidWebViewEngine
 import com.pega.constellation.sdk.kmp.test.mock.MockHttpClient
 import com.pega.constellation.sdk.kmp.test.mock.PegaVersion
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
 import org.junit.runner.RunWith
 import kotlin.test.BeforeTest
 
 @RunWith(AndroidJUnit4::class)
 class ConstellationSdkTest : ConstellationSdkBaseTest() {
     private val appContext = InstrumentationRegistry.getInstrumentation().targetContext
+    private val scope = CoroutineScope(Dispatchers.Main)
 
     @BeforeTest
     fun setup() {
         engine = AndroidWebViewEngine(
             context = appContext,
             okHttpClient = MockHttpClient(appContext, PegaVersion.v24_1_0),
-            nonDxOkHttpClient = MockHttpClient(appContext, PegaVersion.v24_1_0)
+            nonDxOkHttpClient = MockHttpClient(appContext, PegaVersion.v24_1_0),
+            lifecycleScope = scope
         )
     }
 }

ui-renderer-cmp/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/ui/renderer/cmp/containers/ListViewRenderer.kt

@@ -25,9 +25,6 @@ class ListViewRenderer : ComponentRenderer<ListViewComponent> {
                 onItemSelected(it)
             }
         )
-        LaunchedEffect(updateIndex) {
-            checkAutoSubmit()
-        }
     }
 
     private fun SelectionMode.toTableSelectionMode() = when (this) {