Skip to content

Commit e4f6ede

Browse files
ISSUE-139957: additional review fixes
1 parent fe0a76e commit e4f6ede

File tree

6 files changed

+10
-11
lines changed

6 files changed

+10
-11
lines changed

scripts/dxcomponents/components-manager.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ export class ComponentsManager {
4141
*
4242
* @param type - type of component to create
4343
* @param args - arguments to pass to the component's constructor
44-
* @param init - if true, calls the component's init() method after creation
4544
* @returns the created component
4645
*/
4746
create(type, args = []) {

scripts/dxcomponents/components/containers/root-container.component.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ export class RootContainerComponent extends BaseComponent {
104104
};
105105
const viewContainerPConn = PCore.createPConnect(viewContConfig).getPConnect();
106106
if (this.#viewContainerComponent) {
107-
this.#viewContainerComponent.update(viewContainerPConn)
107+
this.#viewContainerComponent.update(viewContainerPConn);
108108
} else {
109-
this.#viewContainerComponent = this.componentsManager.create(viewContainerPConn.meta.type, [viewContainerPConn])
109+
this.#viewContainerComponent = this.componentsManager.create(viewContainerPConn.meta.type, [viewContainerPConn]);
110110
this.#viewContainerComponent.init();
111111
}
112112
}
@@ -124,9 +124,9 @@ export class RootContainerComponent extends BaseComponent {
124124

125125
const modalViewContainerPConn = configObjModal.getPConnect();
126126
if (this.#modalViewContainerComponent) {
127-
this.#modalViewContainerComponent.update(modalViewContainerPConn)
127+
this.#modalViewContainerComponent.update(modalViewContainerPConn);
128128
} else {
129-
this.#modalViewContainerComponent = this.componentsManager.create(modalViewContainerPConn.meta.type, [modalViewContainerPConn])
129+
this.#modalViewContainerComponent = this.componentsManager.create(modalViewContainerPConn.meta.type, [modalViewContainerPConn]);
130130
this.#modalViewContainerComponent.init();
131131
}
132132
if (this.compId !== "1") {

scripts/dxcomponents/components/containers/templates/field-group-template.component.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export class FieldGroupTemplateComponent extends BaseComponent {
101101
).getPConnect();
102102
let newComponent;
103103
if (oldComponent) {
104-
oldComponent.update(newPConn)
104+
oldComponent.update(newPConn);
105105
newComponent = oldComponent;
106106
} else {
107107
newComponent = this.componentsManager.create(newPConn.meta.type, [newPConn]);

scripts/dxcomponents/components/containers/templates/simple-table-manual.component.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,10 +246,10 @@ export class SimpleTableManualComponent extends BaseComponent {
246246
const oldComponent = editableRow?.cells?.[cellIndex]?.component;
247247
let newComponent;
248248
if (oldComponent) {
249-
oldComponent.update(cellPConn)
250-
newComponent = oldComponent
249+
oldComponent.update(cellPConn);
250+
newComponent = oldComponent;
251251
} else {
252-
newComponent = this.componentsManager.create(cellPConn.meta.type, [cellPConn])
252+
newComponent = this.componentsManager.create(cellPConn.meta.type, [cellPConn]);
253253
newComponent.init();
254254
}
255255
newEditableCells.push({ component: newComponent })

scripts/dxcomponents/components/containers/templates/simple-table.component.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export class SimpleTableComponent extends BaseComponent {
7070
if (multiRecordDisplayAs === "fieldGroup") {
7171
const fieldGroupProps = { ...configProps, contextClass };
7272
if (this.childComponent) {
73-
this.childComponent.update(this.pConn, fieldGroupProps)
73+
this.childComponent.update(this.pConn, fieldGroupProps);
7474
} else {
7575
this.childComponent = this.componentsManager.create("FieldGroupTemplate", [this.pConn, fieldGroupProps]);
7676
this.childComponent.init();

scripts/dxcomponents/components/containers/view.component.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export class ViewComponent extends ContainerBaseComponent {
132132
return this.#evaluateVisibilityExpression(contextName, configProps.referenceContext, visibilityExpression);
133133
} else if (visibilityExpression.startsWith("@W ")) {
134134
// when rules does not need special handling
135-
return configProps.visibility
135+
return configProps.visibility;
136136
} else {
137137
console.warn(TAG, `Unsupported visibility expression: ${visibilityExpression}. Defaulting to visible.`);
138138
return true;

0 commit comments

Comments
 (0)