updated as per PR comments

Author: manasa

packages/react-sdk-components/src/components/template/AdvancedSearch/SearchGroups/hooks.ts

@@ -1,6 +1,5 @@
 import { useEffect } from 'react';
 
-// import listViewConstants from '../../ListView/constants';
 const listViewConstants = {
   EVENTS: {
     LIST_VIEW_READY: 'LIST_VIEW_READY'

packages/react-sdk-components/src/components/template/DataReference/DataReference.tsx

@@ -2,7 +2,7 @@ import React, { PropsWithChildren, ReactElement, useEffect, useMemo, useState }
 
 import { getComponentFromMap } from '../../../bridge/helpers/sdk_component_map';
 import { PConnProps } from '../../../types/PConnProps';
-import useIsMount from './useIsMount';
+import useIsMount from '../../../hooks/useIsMount';
 import componentCachePersistUtils from '../AdvancedSearch/SearchGroup/persistUtils';
 import { getMappedKey } from '../AdvancedSearch/SearchGroup/persistUtils';
 import DataReferenceAdvancedSearchContext from './DataReferenceAdvancedSearchContext';
@@ -83,8 +83,8 @@ export default function DataReference(props: PropsWithChildren<DataReferenceProp
   const { allowImplicitRefresh } = isInfinity
     ? PCore.getFieldDefaultUtils().fieldDefaults.DataReference || {}
     : {
-        allowImplicitRefresh: true
-      };
+      allowImplicitRefresh: true
+    };
 
   let firstChildPConnect;
 
@@ -126,12 +126,12 @@ export default function DataReference(props: PropsWithChildren<DataReferenceProp
               const ddDataSource = firstChildMeta.config.datasource.filterDownloadedFields
                 ? res.data.data
                 : res.data.data
-                    .map(listItem => ({
-                      key: listItem[key.split(' .', 2)[1]],
-                      text: listItem[text.split(' .', 2)[1]],
-                      value: listItem[value.split(' .', 2)[1]]
-                    }))
-                    .filter(item => item.key);
+                  .map(listItem => ({
+                    key: listItem[key.split(' .', 2)[1]],
+                    text: listItem[text.split(' .', 2)[1]],
+                    value: listItem[value.split(' .', 2)[1]]
+                  }))
+                  .filter(item => item.key);
               // Filtering out undefined entries that will break preview
               setDropDownDataSource(ddDataSource);
             } else {
@@ -206,7 +206,7 @@ export default function DataReference(props: PropsWithChildren<DataReferenceProp
         getPConnect()
           .getActionsApi()
           .refreshCaseView(caseKey, viewName, pgRef, refreshOptions)
-          .catch(() => {});
+          .catch(() => { });
       }
     } else if (propValue && canBeChangedInReviewMode && isDisplayModeEnabled) {
       (PCore.getDataApiUtils().getCaseEditLock(caseKey, '') as Promise<any>).then(caseResponse => {
@@ -307,7 +307,7 @@ export default function DataReference(props: PropsWithChildren<DataReferenceProp
     ) {
       firstChildMeta.config.datasource.source =
         (firstChildMeta.config.variant === 'card' && dropDownDataSource) ||
-        (firstChildMeta.config.variant !== 'card' && rawViewMetadata.config?.parameters)
+          (firstChildMeta.config.variant !== 'card' && rawViewMetadata.config?.parameters)
           ? dropDownDataSource
           : '@DATASOURCE '.concat(refList).concat('.pxResults');
     } else if (firstChildMeta?.type === 'AutoComplete') {
@@ -372,8 +372,8 @@ export default function DataReference(props: PropsWithChildren<DataReferenceProp
 
     const additionalInfo = refFieldMetadata?.additionalInformation
       ? {
-          content: refFieldMetadata.additionalInformation
-        }
+        content: refFieldMetadata.additionalInformation
+      }
       : undefined;
 
     const dataReferenceConfigToChild = {
@@ -392,14 +392,14 @@ export default function DataReference(props: PropsWithChildren<DataReferenceProp
       }),
       ...(selectionMode === SELECTION_MODE.SINGLE &&
         displayAs === 'advancedSearch' && {
-          value: rawViewMetadata.config.value,
-          contextPage: rawViewMetadata.config.contextPage
-        }),
+        value: rawViewMetadata.config.value,
+        contextPage: rawViewMetadata.config.contextPage
+      }),
       ...(selectionMode === SELECTION_MODE.MULTI &&
         displayAs === 'advancedSearch' && {
-          selectionList,
-          readonlyContextList: rawViewMetadata.config.readonlyContextList
-        }),
+        selectionList,
+        readonlyContextList: rawViewMetadata.config.readonlyContextList
+      }),
       dataRelationshipContext: rawViewMetadata.config.contextClass && rawViewMetadata.config.name ? rawViewMetadata.config.name : null,
       hideLabel,
       onRecordChange: handleSelection,

packages/react-sdk-components/src/components/template/ListView/ListView.tsx

@@ -424,9 +424,8 @@ export default function ListView(props: ListViewProps) {
           [`T${index++}`]: { ...filter[relationalOp][1].condition }
         };
         if (dashboardFilterPayload.query.filter.logic) {
-          dashboardFilterPayload.query.filter.logic = `${dashboardFilterPayload.query.filter.logic} ${relationalOp} (T${
-            index - 2
-          } ${dateRelationalOp} T${index - 1})`;
+          dashboardFilterPayload.query.filter.logic = `${dashboardFilterPayload.query.filter.logic} ${relationalOp} (T${index - 2
+            } ${dateRelationalOp} T${index - 1})`;
         } else {
           dashboardFilterPayload.query.filter.logic = `(T${index - 2} ${relationalOp} T${index - 1})`;
         }
@@ -485,9 +484,9 @@ export default function ListView(props: ListViewProps) {
     // getDataAsync isn't returning correct data for the Page(i.e. ListView within a page) case
     return !bInForm
       ? // @ts-ignore - 3rd parameter "context" should be optional in getData method
-        PCore.getDataApiUtils().getData(referenceList, payload)
+      PCore.getDataApiUtils().getData(referenceList, payload)
       : // @ts-ignore - Argument of type 'null' is not assignable to parameter of type 'object'
-        PCore.getDataPageUtils().getDataAsync(referenceList, context, payload ? payload.dataViewParameters : dataViewParameters, null, query);
+      PCore.getDataPageUtils().getDataAsync(referenceList, context, payload ? payload.dataViewParameters : dataViewParameters, null, query);
   }
 
   const buildSelect = (fieldDefs, colId, patchQueryFields = [], compositeKeys = []) => {
@@ -1228,7 +1227,7 @@ export default function ListView(props: ListViewProps) {
                         })}
                   </TableBody>
                 </Table>
-                {((arRows && arRows.length === 0) || !arRows) && (
+                {(!arRows || arRows.length === 0) && (
                   <div className='no-records'>{getGenericFieldsLocalizedValue('CosmosFields.fields.lists', 'No records found.')}</div>
                 )}
               </TableContainer>